New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719974 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

WebViewLayoutTests failing on 2 builders since May 4

Project Member Reported by hartma...@chromium.org, May 9 2017

Issue description

Cc: boliu@chromium.org
+boliu because this involves webview tests, which you presumably know a lot better than me.

First failure: https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20M%20%28dbg%29/builds/4674

The only change in the blamelist that looks potentially related to me is https://codereview.chromium.org/2856913002, is it possible that it could be the cause?

log snippet:

I   71.080s run_tests_on_device(0d88c4e143e4bab5)    Error in testWebViewIncludedStableInterfaces(org.chromium.webview_shell.test.WebViewLayoutTest):
I   71.080s run_tests_on_device(0d88c4e143e4bab5)    org.junit.ComparisonFailure: Missing webview interfaces found expected:<[]> but was:<[interface HTMLIFrameElement : HTMLElement.getter allowPaymentRequest
I   71.081s run_tests_on_device(0d88c4e143e4bab5)    interface HTMLIFrameElement : HTMLElement.setter allowPaymentRequest
I   71.081s run_tests_on_device(0d88c4e143e4bab5)    interface PaymentAddress
I   71.081s run_tests_on_device(0d88c4e143e4bab5)    interface PaymentRequest : EventTarget
I   71.081s run_tests_on_device(0d88c4e143e4bab5)    interface PaymentRequestUpdateEvent : Event
I   71.081s run_tests_on_device(0d88c4e143e4bab5)    interface PaymentResponse
I   71.081s run_tests_on_device(0d88c4e143e4bab5)    ]>
I   71.081s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.Assert.assertEquals(Assert.java:115)
I   71.082s run_tests_on_device(0d88c4e143e4bab5)    	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:236)
I   71.082s run_tests_on_device(0d88c4e143e4bab5)    	at java.lang.reflect.Method.invoke(Native Method)
I   71.082s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
I   71.082s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
I   71.082s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
I   71.082s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
I   71.082s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
I   71.083s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
I   71.083s run_tests_on_device(0d88c4e143e4bab5)    	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
I   71.083s run_tests_on_device(0d88c4e143e4bab5)    	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
I   71.083s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
I   71.083s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
I   71.083s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
I   71.083s run_tests_on_device(0d88c4e143e4bab5)    	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:134)
I   71.084s run_tests_on_device(0d88c4e143e4bab5)    	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:35)
I   71.084s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
I   71.084s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I   71.084s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
I   71.084s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
I   71.084s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
I   71.084s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.Suite.runChild(Suite.java:128)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.Suite.runChild(Suite.java:27)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
I   71.085s run_tests_on_device(0d88c4e143e4bab5)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)

Comment 2 by boliu@chromium.org, May 9 2017

Owner: timvolod...@chromium.org
some js interface change I think
The CTS failure started here, after the system webview shell test failure: https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20L%20%28dbg%29/builds/4716

which most likely is caused by this CL: https://codereview.chromium.org/2801813005

add +avi

I will disable these two tests for now here: https://codereview.chromium.org/2874533002
Cc: a...@chromium.org yolandyan@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, May 10 2017

Project Member

Comment 8 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53cbba636ebdaff456dc42d4356c353e2fdcb38

commit f53cbba636ebdaff456dc42d4356c353e2fdcb38
Author: timvolodine <timvolodine@chromium.org>
Date: Thu May 11 15:40:04 2017

Re-enable WebView stable interfaces layout test.

Update not-webview-exposed.txt (allowPaymentRequest) and
re-enable the testWebViewIncludedStableInterfaces test.

BUG= 719974 
NOTRY=true
TBR=yolandyan@chromium.org,avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2877783002
Cr-Commit-Position: refs/heads/master@{#470966}

[modify] https://crrev.com/f53cbba636ebdaff456dc42d4356c353e2fdcb38/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
[modify] https://crrev.com/f53cbba636ebdaff456dc42d4356c353e2fdcb38/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

Status: Fixed (was: Started)
bots green, this one is fixed
Status: Assigned (was: Fixed)
Hi Tim, it seemed that you only fixed part of the issue, the test case testOnJsBeforeUnloadIsCalled is still failed, but it has been disabled in our cts bot, now it also failed in oc-rm1, I assigned the b/64152248 to you.
Hmm, yes looks like this got confused somehow, there are two issues in this bug..

I've spun off the CTS issue into a separate bug crbug.com/757007
Summary: WebViewLayoutTests failing on 2 builders since May 4 (was: Run CTS failing on 2 builders since May 4)
Status: Fixed (was: Assigned)
Cc: ntfschr@chromium.org changwan@chromium.org
Status: Assigned (was: Fixed)
I think this is related to http://b/64152248.

We have fixed the CTS test on master, OMR1, O, and I *think* nougat. Is it reasonable to enable this test again?
Status: Fixed (was: Assigned)
Right, this bug is about LayoutTests that have been fixed. So marking this one as fixed.

Will continue with the CTS issue on crbug.com/757007 (which has been spun off for this reason)

Sign in to add a comment