New issue
Advanced search Search tips

Issue 719968 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 716066



Sign in to add a comment

Add a command line flag to enable the internal media session without audio focus

Project Member Reported by mlamouri@chromium.org, May 9 2017

Issue description

--enable-default-media-session actually turns on audio focus. There is interest to use the internal media session to control playback without turning on audio focus. For this, we will create another flag: --enable-internal-media-session but to avoid confusion, the current flag will be renamed --enable-audio-focus.
 
Blocking: 716066
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff56c0909be1a23d43a31ba9acb45964cd1a3256

commit ff56c0909be1a23d43a31ba9acb45964cd1a3256
Author: mlamouri <mlamouri@chromium.org>
Date: Thu May 11 15:31:39 2017

Rename --enable-default-media-session to --enable-audio-focus.

The flag matches reality and will allow to introduce a flag that will
enable the MediaSession code without turning on the audio focus
behaviour.

BUG= 719968 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2871583004
Cr-Commit-Position: refs/heads/master@{#470965}

[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/chrome/browser/about_flags.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/chrome/browser/resources/chromeos/chromevox/cvox2/background/media_automation_handler.js
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/content/browser/media/session/audio_focus_delegate_default.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/content/browser/media/session/audio_focus_delegate_default_browsertest.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/content/browser/media/session/audio_focus_manager_unittest.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/content/browser/media/session/media_session_controllers_manager.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/content/browser/media/session/media_session_impl_visibility_browsertest.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/content/browser/media/session/pepper_playback_observer.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/content/browser/media/session/pepper_player_delegate.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/media/base/media_switches.cc
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/media/base/media_switches.h
[modify] https://crrev.com/ff56c0909be1a23d43a31ba9acb45964cd1a3256/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment