New issue
Advanced search Search tips

Issue 719953 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.8%-12.7% regression in v8.runtimestats.browsing_mobile_classic at 469772:469836

Project Member Reported by tebbi@google.com, May 9 2017

Issue description

See the link to graphs below.
 
Cc: jgruber@chromium.org
Owner: jgruber@chromium.org

=== Auto-CCing suspected CL author jgruber@chromium.org ===

Hi jgruber@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jgruber
  Commit : f0e95769dbc3c209f513c68e2aa7c9433c4cd934
  Date   : Fri May 05 15:59:08 2017
  Subject: [string] Move String.p.toLowerCase to CSA

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile
  Metric       : API:duration_avg/browse_shopping/browse_shopping_lazada
  Change       : 15.88% | 255.168666667 -> 295.682833333

Revision                           Result                  N
chromium@469823                    255.169 +- 14.5629      6      good
chromium@469826                    256.339 +- 17.1036      6      good
chromium@469827                    263.092 +- 26.2206      9      good
chromium@469827,v8@02a7c020bd      261.47 +- 14.4076       6      good
chromium@469827,v8@1cda1732a7      259.331 +- 21.8359      6      good
chromium@469827,v8@f0e95769db      287.712 +- 11.7342      6      bad       <--
chromium@469828                    285.063 +- 16.2292      6      bad
chromium@469832                    295.683 +- 15.5778      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.shopping.lazada v8.runtimestats.browsing_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980064588507796992

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5825701581684736


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
The CL from #3 shifts execution of String.p.toLowerCase from C++ runtime to a CSA builtin. I *think* what's happening is that runtime is being shifted around between different buckets, as Total:duration_avg is unaffected [0]. Closing for now but may reopen if something turns up.

[0] https://chromeperf.appspot.com/report?sid=d743d5b9c8ab6a5cb4c8579e14396caaa908ad8faed39c61d91eb2f59c9293c6
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, May 13 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile_classic
  Metric       : v8-gc-memory-mark-compactor_avg/browse_tools/browse_tools_maps
  Change       : 85.47% | 14.2407333333 -> 26.4126666667

Suspected Commit Range
  3 commits in range
  https://chromium.googlesource.com/chromium/src/+log/09721eaab9e4d8dd62796f991da68dc2b89a325c..e26d614b628f59bb4bab84121056ead36932fbba


Revision             Result                  N
chromium@469608      14.2407 +- 1.83739      5        good
chromium@469644      14.2973 +- 5.77684      5        good
chromium@469653      14.6835 +- 3.10488      6        good
chromium@469654      ---                     ---      build failure
chromium@469655      ---                     ---      build failure
chromium@469656      26.3108 +- 6.37279      7        bad
chromium@469658      24.3672 +- 4.98535      5        bad
chromium@469662      26.6146 +- 1.94395      6        bad
chromium@469679      25.7633 +- 3.20696      6        bad
chromium@469750      26.3446 +- 3.81946      7        bad
chromium@469893      26.4127 +- 2.85864      6        bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.tools.maps v8.runtimestats.browsing_mobile_classic

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979816624617453792

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5047105615298560


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Sign in to add a comment