Edit button is not disabled after deleting all items from “Block pop-ups” |
||||
Issue descriptionApp Version: 60.0.3094.0 iOS Version: 10.2.1, 10.3.1, 9.3.5 Device: iPhone, iPad URL: popuptest.com Steps to reproduce: 1. Launch chrome and navigate to above mentioned URL 2. Tap on any link that opens multiple popup 3. Tap on always show in infobar 4. Open settings>>Content Settings>>Block popups and tap on edit button 5. Select all the items from allowed pop-up and tap on delete button Observed results: Notice edit button is not disabled. Expected results: If there is no data in the block pop-up the edit button should be disabled. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Firefox/Safari: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): Yes on M58 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M59 Link to video/image: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8a1pRYVd6V2lFSTg/view?usp=sharing
,
Nov 17 2017
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/568e79bccd70348b1cd4dcc58db7c0074442d8e1 commit 568e79bccd70348b1cd4dcc58db7c0074442d8e1 Author: Louis Romero <lpromero@chromium.org> Date: Mon Nov 20 12:39:26 2017 Update the edit button when all entries are gone. Bug: 719940 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3f4ca925dd4e4378e5f7ae8fcb5276660a9cb5fc Reviewed-on: https://chromium-review.googlesource.com/776816 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517801} [modify] https://crrev.com/568e79bccd70348b1cd4dcc58db7c0074442d8e1/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
,
Nov 20 2017
,
Nov 23 2017
Verified on 64.0.3276.0 Canary in iPhone 8plus(iOS 11.2 beta4) and iPad Mini(iOS 10.3.3) Edit button is now disabled after deleting all items from “Block pop-ups”, looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by sczs@chromium.org
, May 10 2017Owner: lpromero@chromium.org
Status: Assigned (was: Untriaged)