New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719933 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: bound_textures_.find(target) != bound_textures_.end() in gles2_cmd_decoder_passt

Project Member Reported by ClusterFuzz, May 9 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6737136505323520

Fuzzer: libfuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  bound_textures_.find(target) != bound_textures_.end() in gles2_cmd_decoder_passt
  base::debug::DebugBreak
  gpu::gles2::GLES2DecoderPassthroughImpl::DoBindTexture
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=470025:470101

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6737136505323520


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong-CLs M-60
Owner: jbau...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "gles2_cmd_decoder_passthrough_doers.cc" assigning to the concern owner.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/d817ddec78c9de78881a1661fa7f03e077d32d36

@jbauman -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: jbau...@chromium.org
Owner: geoffl...@chromium.org
Unlikely to be my change. Maybe it's happening because bound_textures_[GL_TEXTURE_EXTERNAL_OES] isn't being initialized?
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59d2ca1729430fc7713e642d04a772773248f030

commit 59d2ca1729430fc7713e642d04a772773248f030
Author: geofflang <geofflang@chromium.org>
Date: Wed May 31 15:16:50 2017

Track currently bound external and multisample textures.

This caused assertions in glBindTexture even when binding 0. Caught by
the fuzzer which uses an ES 3.1 context.

BUG= 726265 
BUG= 719933 
BUG= 719803 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2909683002
Cr-Commit-Position: refs/heads/master@{#475912}

[modify] https://crrev.com/59d2ca1729430fc7713e642d04a772773248f030/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Project Member

Comment 4 by ClusterFuzz, Jun 2 2017

ClusterFuzz has detected this issue as fixed in range 476422:476483.

Detailed report: https://clusterfuzz.com/testcase?key=6737136505323520

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  bound_textures_.find(target) != bound_textures_.end() in gles2_cmd_decoder_passt
  base::debug::DebugBreak
  gpu::gles2::GLES2DecoderPassthroughImpl::DoBindTexture
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=470025:470101
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=476422:476483

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6737136505323520


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Jun 2 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6737136505323520 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab3a2e8b39dfbf6d9e76b413f995c119da103bb4

commit ab3a2e8b39dfbf6d9e76b413f995c119da103bb4
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jun 13 20:18:34 2017

Validate context loss reason for glLoseContextCHROMIUM.

BUG= 719933 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5acfc74bacc77c4cbad654019bc05e701c85b160
Reviewed-on: https://chromium-review.googlesource.com/531834
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479122}
[modify] https://crrev.com/ab3a2e8b39dfbf6d9e76b413f995c119da103bb4/gpu/command_buffer/service/gl_utils.cc
[modify] https://crrev.com/ab3a2e8b39dfbf6d9e76b413f995c119da103bb4/gpu/command_buffer/service/gl_utils.h
[modify] https://crrev.com/ab3a2e8b39dfbf6d9e76b413f995c119da103bb4/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Sign in to add a comment