We should move the GPU service to the viz directory. GpuMain should probably be called VizMain.
I'm going to go out on a limb and say we should unify gpu_child_thread and viz's GpuMain before shipping. Maybe we can bundle that code under this bug?
I am not sure I agree. We can ship code in gpu_child_thread just fine, and then port that into servicification later.
You're right. I would bundle that under "technical debt", but as discussed offline, we don't need to block on it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b commit 950d9d8673a279b9c739db2b9d0aab5ae7f82e3b Author: sadrul <sadrul@chromium.org> Date: Thu Jun 15 21:10:15 2017 viz: Move some code into //components/viz/common. Move ServerGpuMemoryBufferManager out of //services/ui/common into //components/viz/common. It is used in both the host process (to allocate memory for clients), and the viz process (by the display compositor). BUG= 719931 TBR=jbauman@ for unused dependency removal from content/gpu/BUILD.gn Review-Url: https://codereview.chromium.org/2939953004 Cr-Commit-Position: refs/heads/master@{#479830} [add] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/components/viz/common/BUILD.gn [add] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/components/viz/common/DEPS [add] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/components/viz/common/README.md [rename] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/components/viz/common/server_gpu_memory_buffer_manager.cc [rename] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/components/viz/common/server_gpu_memory_buffer_manager.h [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/content/gpu/BUILD.gn [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/common/BUILD.gn [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/gpu/BUILD.gn [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/gpu/gpu_main.cc [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/ws/BUILD.gn [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/ws/DEPS [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/ws/gpu_client.cc [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/ws/gpu_client.h [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/ws/gpu_host.cc [modify] https://crrev.com/950d9d8673a279b9c739db2b9d0aab5ae7f82e3b/services/ui/ws/gpu_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef1abe7870c631a402294f94b614446d30bba787 commit ef1abe7870c631a402294f94b614446d30bba787 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Aug 01 17:20:38 2017 viz: Move GpuService into the right place. GpuService is a privileged interface used by the viz-host to communicate with the viz-service. Therefore: . Move the mojom API to //services/viz/gl/privileged/interfaces. . Move the implementation to //components/viz/service/gl. BUG= 719931 NOPRESUBMIT=True (because of existing use of RunLoop::QuitCurrent*() in moved files). Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I16e35bc85d239d4e5a9f929b2d89501c80310a77 Reviewed-on: https://chromium-review.googlesource.com/590773 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491034} [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/README.md [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/host/DEPS [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/host/server_gpu_memory_buffer_manager.cc [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/host/server_gpu_memory_buffer_manager.h [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/service/BUILD.gn [add] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/service/gl/DEPS [rename] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/service/gl/gpu_service_impl.cc [rename] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/service/gl/gpu_service_impl.h [rename] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/components/viz/service/gl/gpu_service_impl_unittest.cc [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/content/browser/gpu/gpu_ipc_browsertests.cc [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/content/browser/gpu/gpu_process_host.h [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/content/gpu/DEPS [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/content/gpu/gpu_child_thread.cc [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/content/gpu/gpu_child_thread.h [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/media/gpu/ipc/service/BUILD.gn [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/BUILD.gn [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/gpu/BUILD.gn [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/gpu/DEPS [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/gpu/gpu_main.cc [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/gpu/gpu_main.h [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/gpu/interfaces/BUILD.gn [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/gpu/interfaces/gpu_main.mojom [delete] https://crrev.com/2d3fddeaf6523fe183876b66a70498af8f45a786/services/ui/gpu/test_manifest.json [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/ws/DEPS [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/ws/gpu_client.cc [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/ws/gpu_client.h [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/ws/gpu_host.h [modify] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/ui/ws/gpu_host_unittest.cc [add] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/viz/gl/privileged/interfaces/BUILD.gn [add] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/viz/gl/privileged/interfaces/OWNERS [rename] https://crrev.com/ef1abe7870c631a402294f94b614446d30bba787/services/viz/gl/privileged/interfaces/gpu_service.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57 commit 0ff5528b743b2e98d1eb103fe2dd144b07ab4d57 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Thu Oct 12 20:53:19 2017 viz: Move mojom.GpuHost into viz. Move mojom.GpuHost out of services/ui/gpu into services/viz/privileged. Change namespace from ui:: to viz:: accordingly. BUG= 719931 TBR=piman@ for content/browser, yzshen@ for mojo/public for trivial changes Change-Id: Ib2acf2b47ed8c3cbbe0829ad76ee078bc2a6b138 Reviewed-on: https://chromium-review.googlesource.com/716697 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#508454} [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/components/viz/service/gl/gpu_service_impl.cc [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/components/viz/service/gl/gpu_service_impl.h [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/content/browser/gpu/gpu_process_host.h [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/ui/gpu/gpu_main.cc [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/ui/gpu/gpu_main.h [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/ui/gpu/interfaces/BUILD.gn [delete] https://crrev.com/24fba7b46d793b9ff2f1f6b664a216ac582a7c16/services/ui/gpu/interfaces/context_lost_reason.typemap [delete] https://crrev.com/24fba7b46d793b9ff2f1f6b664a216ac582a7c16/services/ui/gpu/interfaces/context_lost_reason_traits.h [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/ui/gpu/interfaces/gpu_main.mojom [delete] https://crrev.com/24fba7b46d793b9ff2f1f6b664a216ac582a7c16/services/ui/gpu/interfaces/typemaps.gni [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/ui/ws/gpu_host.cc [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/ui/ws/gpu_host.h [add] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/viz/privileged/cpp/DEPS [add] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/viz/privileged/cpp/OWNERS [add] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/viz/privileged/cpp/context_lost_reason.typemap [add] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/viz/privileged/cpp/context_lost_reason_traits.h [add] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/viz/privileged/cpp/typemaps.gni [modify] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/viz/privileged/interfaces/gl/BUILD.gn [rename] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/viz/privileged/interfaces/gl/context_lost_reason.mojom [rename] https://crrev.com/0ff5528b743b2e98d1eb103fe2dd144b07ab4d57/services/viz/privileged/interfaces/gl/gpu_host.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55fc2f0bebac5a428bbfc6891666df976b3fb180 commit 55fc2f0bebac5a428bbfc6891666df976b3fb180 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Oct 27 02:40:06 2017 viz: Move ui.mojom.GpuMain into viz.mojom.VizMain. Rename the implementations appropriately as well. BUG= 719931 TBR=piman@, tsepez@, for file-move updates Change-Id: I3cb568b590fdc9ea8a63dfbdf1fe101b106aecef Reviewed-on: https://chromium-review.googlesource.com/740341 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#512067} [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/components/viz/common/DEPS [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/components/viz/host/BUILD.gn [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/components/viz/service/BUILD.gn [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/components/viz/service/gl/DEPS [rename] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/components/viz/service/main/BUILD.gn [add] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/components/viz/service/main/DEPS [rename] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/components/viz/service/main/viz_main_impl.cc [rename] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/components/viz/service/main/viz_main_impl.h [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/browser/BUILD.gn [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/browser/gpu/gpu_process_host.h [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/gpu/BUILD.gn [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/gpu/DEPS [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/gpu/gpu_child_thread.cc [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/gpu/gpu_child_thread.h [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/gpu/gpu_main.cc [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/public/app/mojo/content_gpu_manifest.json [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/content/test/BUILD.gn [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/ui/DEPS [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/ui/common/DEPS [delete] https://crrev.com/920bdc038a677bd4d6e8f46f03c4829f484dcd7f/services/ui/gpu/DEPS [delete] https://crrev.com/920bdc038a677bd4d6e8f46f03c4829f484dcd7f/services/ui/gpu/OWNERS [delete] https://crrev.com/920bdc038a677bd4d6e8f46f03c4829f484dcd7f/services/ui/gpu/interfaces/BUILD.gn [delete] https://crrev.com/920bdc038a677bd4d6e8f46f03c4829f484dcd7f/services/ui/gpu/interfaces/OWNERS [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/ui/ws/BUILD.gn [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/ui/ws/DEPS [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/ui/ws/gpu_host.cc [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/ui/ws/gpu_host.h [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/viz/BUILD.gn [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/viz/DEPS [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/viz/manifest.json [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/viz/privileged/interfaces/BUILD.gn [rename] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/viz/privileged/interfaces/viz_main.mojom [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/viz/service.cc [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/viz/service.h [modify] https://crrev.com/55fc2f0bebac5a428bbfc6891666df976b3fb180/services/viz/test_manifest.json
services/ui/gpu is now gone. Finally.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/195a4bf5c6e8d7237f22dc3cba8b59598f5c1190 commit 195a4bf5c6e8d7237f22dc3cba8b59598f5c1190 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Oct 27 17:00:43 2017 viz: Remove the broken OWNERS file for now. Will land a separate CL with the updated path, because simply updating the file with the right path still fails presubmit. BUG= 719931 , 778870 Change-Id: I0f1e44fd1aa90c98b8597a347abe51fa573d5c21 Reviewed-on: https://chromium-review.googlesource.com/740978 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#512215} [delete] https://crrev.com/63d08bd8c480ed251038a0b8626e986e54d80d26/services/ui/public/cpp/gpu/OWNERS
Comment 1 by fsam...@chromium.org
, May 23 2017