[PolyGerrit] Clicking on the "CQ Dry Run" & "Submit to CQ" buttons is not doing anything |
|||||||
Issue descriptionThis is happening after the latest PG push. Reproduced this on both skia-review: https://skia-review.googlesource.com/c/10298/ and chromium-review: https://chromium-review.googlesource.com/c/490766/ Workaround is to click on the "Reply" button and then to click on +1 or +2 next to "Commit-Queue".
,
May 9 2017
,
May 9 2017
Does not look like any recent changes to commitqueue.js caused this. I went back to a version from 1/25/2017 and still see the problem. Something changed in the framework code.
,
May 9 2017
This started happening as of https://gerrit.googlesource.com/gerrit/+/e7bc47f648241fd6610b5ee8f61c919774e5ddc6 I suspect https://gerrit-review.googlesource.com/c/103854 Still looking at why this might happen..
,
May 9 2017
(I am off corp) can you loop in Gerrit team in IRC ? Munich office is likely still online, maybe they can do roll back.
,
May 9 2017
When I revert https://gerrit.googlesource.com/gerrit/+/a499e3d9382fef139294472f4853d0d8f7e76931 locally the buttons start working again.
,
May 9 2017
,
May 9 2017
It appears that the new this.$.labelScores.getLabelValues() is not getting the latest values in send() when the "CQ Dry Run" & "Submit to CQ" buttons are clicked. The old structure in https://gerrit.googlesource.com/gerrit/+/87df78a64899f794abfad47a7963cadb0341fe46/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js#276 was able to get the latest values.
,
May 9 2017
,
May 9 2017
,
May 9 2017
Aaron created a revert in https://gerrit-review.googlesource.com/c/106272
,
May 9 2017
Issue gerrit:6167 has been merged into this issue.
,
May 9 2017
Issue gerrit:6164 has been merged into this issue.
,
May 9 2017
Issue gerrit:6165 has been merged into this issue.
,
May 9 2017
I can't assign this to becky because this bug is in /p/chromium instead of /p/gerrit, but she has a fix here: https://gerrit-review.googlesource.com/c/106410/ Ravi has tested it locally and it works. Next step is to import and deploy to canary.
,
May 9 2017
,
May 9 2017
agable to verify
,
May 9 2017
Tested it in production with: * https://skia-review.googlesource.com/c/10298/ * https://chromium-review.googlesource.com/c/490766/ LGTM Side topic: Can we make some of the PG team contributors in /p/chromium monorail? Would be useful to keep them as owners on bugs like this and https://bugs.chromium.org/p/chromium/issues/detail?id=713194 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rmis...@google.com
, May 9 2017Owner: rmis...@google.com
Status: Assigned (was: Untriaged)