Issue metadata
Sign in to add a comment
|
Search geolocation disclosure is shown for navigations to anything on the DSE origin |
||||||||||||||||||||||||
Issue descriptionWhile this is safe as it is, it probably should only be shown for navigations which cause the X-Geo header to be sent. We would continue to also show it on any access to the geolocation api when the DSE setting causes access to be granted. Lucas - I think this is the bug you mentioned to me a couple of days ago.
,
May 9 2017
In my case, it was for an AMP article, but it may have been only for google.com search page loads. In any case, this sounds like good behaviour regardless. :-)
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44b1737f716e05cdf18fd566d011ce9e915416d0 commit 44b1737f716e05cdf18fd566d011ce9e915416d0 Author: benwells <benwells@chromium.org> Date: Thu May 18 06:31:17 2017 Only show search geolocation disclosure on omnibox searches or API use. Previously the disclosure was shown on all navigations to the search engine origin, which can show disclosures when geolocation is not being used. Now it is only shown for omnibox searches, which send the X-Geo header, or for the geolocation API use. BUG= 719904 Review-Url: https://codereview.chromium.org/2885763002 Cr-Commit-Position: refs/heads/master@{#472707} [modify] https://crrev.com/44b1737f716e05cdf18fd566d011ce9e915416d0/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc [modify] https://crrev.com/44b1737f716e05cdf18fd566d011ce9e915416d0/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h [modify] https://crrev.com/44b1737f716e05cdf18fd566d011ce9e915416d0/chrome/browser/geolocation/geolocation_permission_context_android.cc
,
May 18 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by syah.adi...@gmail.com
, May 9 2017