New issue
Advanced search Search tips

Issue 719857 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task

Blocking:
issue 627945



Sign in to add a comment

Move layout tests for PaintWorklet from csspaint/ to http/tests/

Project Member Reported by nhiroki@chromium.org, May 9 2017

Issue description

After ES6 modules loading for PaintWorklet ( issue 627945 ) is introduced, layout tests of PaintWorklet are no longer able to run on non-http environment because ES6 modules does not support "file://" url (yet? See  https://crbug.com/594639#c86 ).
 
Cc: kouhei@chromium.org
Labels: -Type-Bug OS-All Type-Task
Cc: ikilpatrick@chromium.org
Status: Started (was: Assigned)
CL: https://codereview.chromium.org/2868003002/

Comment 4 by shend@chromium.org, May 10 2017

Labels: Update-Monthly
Project Member

Comment 5 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8da913d44ef4a4846ac31d5bc66dc253d5f150e

commit a8da913d44ef4a4846ac31d5bc66dc253d5f150e
Author: nhiroki <nhiroki@chromium.org>
Date: Thu May 11 21:25:17 2017

Worklet: Move tests for Worklet in inspector/console/ to http/tests/inspector/console/

After ES6 modules loading for PaintWorklet ( issue 627945 ) is introduced, layout
tests for PaintWorklet are no longer able to run on non-http environment because
ES6 modules does not support "file://" url (See  https://crbug.com/594639#c86 ).

This CL moves the tests in inspector/console/ to http/tests/inspector/console/
to enable them to run with module loading.

BUG= 719857 

Review-Url: https://codereview.chromium.org/2881443003
Cr-Commit-Position: refs/heads/master@{#471076}

[modify] https://crrev.com/a8da913d44ef4a4846ac31d5bc66dc253d5f150e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/a8da913d44ef4a4846ac31d5bc66dc253d5f150e/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/a8da913d44ef4a4846ac31d5bc66dc253d5f150e/third_party/WebKit/LayoutTests/http/tests/inspector/console/console-on-animation-worklet-expected.txt
[rename] https://crrev.com/a8da913d44ef4a4846ac31d5bc66dc253d5f150e/third_party/WebKit/LayoutTests/http/tests/inspector/console/console-on-animation-worklet.html
[rename] https://crrev.com/a8da913d44ef4a4846ac31d5bc66dc253d5f150e/third_party/WebKit/LayoutTests/http/tests/inspector/console/console-on-paint-worklet-expected.txt
[rename] https://crrev.com/a8da913d44ef4a4846ac31d5bc66dc253d5f150e/third_party/WebKit/LayoutTests/http/tests/inspector/console/console-on-paint-worklet.html
[rename] https://crrev.com/a8da913d44ef4a4846ac31d5bc66dc253d5f150e/third_party/WebKit/LayoutTests/http/tests/inspector/console/console-worklet-script.js

Project Member

Comment 6 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a71bdb09d0b4e789a045820895ab3535bffddabf

commit a71bdb09d0b4e789a045820895ab3535bffddabf
Author: nhiroki <nhiroki@chromium.org>
Date: Wed May 24 05:37:30 2017

CSSPaint: Move layout tests in csspaint/ to http/tests/csspaint/

After ES6 modules loading for PaintWorklet ( issue 627945 ) is introduced, layout
tests for PaintWorklet are no longer able to run on non-http environment because
ES6 modules does not support "file://" url (See  https://crbug.com/594639#c86 ).

This CL moves layout tests in csspaint/ to http/tests/csspaint/, and copies
resources/run-after-layout-and-paint.js into http/tests/resources/.

BUG= 719857 

Review-Url: https://codereview.chromium.org/2868003002
Cr-Commit-Position: refs/heads/master@{#474174}

[modify] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/b303c28a8002db42825e3b12f3fd956f3c32ecab/third_party/WebKit/LayoutTests/csspaint/invalidation-background-image-expected.txt
[delete] https://crrev.com/b303c28a8002db42825e3b12f3fd956f3c32ecab/third_party/WebKit/LayoutTests/csspaint/invalidation-border-image-expected.txt
[delete] https://crrev.com/b303c28a8002db42825e3b12f3fd956f3c32ecab/third_party/WebKit/LayoutTests/csspaint/invalidation-content-image-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-alpha-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-alpha.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-multiple-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-multiple.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-tiled-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-tiled.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image-tiled-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image-tiled.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-border-image-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-border-image.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-constructor-error-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-constructor-error.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-paint-error-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-paint-error.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-pending-script-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-pending-script.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalidation-background-image.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalidation-border-image.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/invalidation-content-image.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/overdraw-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/overdraw.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint-arguments-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint-arguments.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint-function-arguments-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint-function-arguments.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-composite-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-composite.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-gradient-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-gradient.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-image-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-image.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-paths-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-paths.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-rects-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-rects.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-shadows-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-shadows.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-transform-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-transform.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-zoom-expected.png
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-zoom-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-zoom.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/parse-input-arguments-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/parse-input-arguments.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/registerPaint-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/registerPaint.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/registered-properties-in-custom-paint-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/registered-properties-in-custom-paint.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/resources/generate-paint-style-logging.js
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/resources/html5.png
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/resources/paint-logging-green.js
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-geometry-logging.js
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-invalidation-logging.js
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-paint-helper.js
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-paint-worklet.js
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/style-background-image-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/style-background-image.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/style-before-pseudo-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/style-before-pseudo.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/style-first-letter-pseudo-expected.txt
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/style-first-letter-pseudo.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/valid-image-after-load-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/valid-image-after-load.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/valid-image-before-load-expected.html
[rename] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/csspaint/valid-image-before-load.html
[add] https://crrev.com/a71bdb09d0b4e789a045820895ab3535bffddabf/third_party/WebKit/LayoutTests/http/tests/resources/run-after-layout-and-paint.js

Labels: M-60
Status: Fixed (was: Started)

Sign in to add a comment