waitUntil() should wait until all promises got resolved/rejected. |
||
Issue descriptionSpec: https://w3c.github.io/ServiceWorker/#wait-until-method For multiple waitUntil() pending promises, even if some one got rejected while some others are still pending at the same time, we should continue waiting, until all pending promises completed(resolved or rejected). Fixing this bug will make third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/extendable-event-waituntil.https.html all PASS.
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06f33f6fa8d71e31838103a0e12f95e8420510d2 commit 06f33f6fa8d71e31838103a0e12f95e8420510d2 Author: leon.han <leon.han@intel.com> Date: Thu May 11 05:46:54 2017 [ServiceWorker] waitUntil() should wait until all promises got resolved/rejected. Spec: https://w3c.github.io/ServiceWorker/#wait-until-method For multiple waitUntil() pending promises, even if some one got rejected while some others are still pending at the same time, we should continue waiting, until all pending promises completed(resolved or rejected). BUG= 719850 TEST=blink_tests external/wpt/service-workers/service-worker/extendable-event-waituntil.https.html TBR=kinuko@chromium.org Review-Url: https://codereview.chromium.org/2867023002 Cr-Commit-Position: refs/heads/master@{#470828} [delete] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/extendable-event-waituntil.https-expected.txt [modify] https://crrev.com/06f33f6fa8d71e31838103a0e12f95e8420510d2/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp [modify] https://crrev.com/06f33f6fa8d71e31838103a0e12f95e8420510d2/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h [modify] https://crrev.com/06f33f6fa8d71e31838103a0e12f95e8420510d2/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
,
May 12 2017
Thanks for filing and fixing!
,
Aug 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by falken@chromium.org
, May 9 2017