New issue
Advanced search Search tips

Issue 719850 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

waitUntil() should wait until all promises got resolved/rejected.

Project Member Reported by leon....@intel.com, May 9 2017

Issue description

Spec: https://w3c.github.io/ServiceWorker/#wait-until-method

For multiple waitUntil() pending promises, even if some one got rejected
while some others are still pending at the same time, we should continue
waiting, until all pending promises completed(resolved or rejected).

Fixing this bug will make 
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/extendable-event-waituntil.https.html all PASS.

 
Blocking: 678905
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06f33f6fa8d71e31838103a0e12f95e8420510d2

commit 06f33f6fa8d71e31838103a0e12f95e8420510d2
Author: leon.han <leon.han@intel.com>
Date: Thu May 11 05:46:54 2017

[ServiceWorker] waitUntil() should wait until all promises got resolved/rejected.

Spec: https://w3c.github.io/ServiceWorker/#wait-until-method

For multiple waitUntil() pending promises, even if some one got rejected
while some others are still pending at the same time, we should continue
waiting, until all pending promises completed(resolved or rejected).

BUG= 719850 
TEST=blink_tests
external/wpt/service-workers/service-worker/extendable-event-waituntil.https.html
TBR=kinuko@chromium.org

Review-Url: https://codereview.chromium.org/2867023002
Cr-Commit-Position: refs/heads/master@{#470828}

[delete] https://crrev.com/6156f7b21c2555d4ce52cecff7f5851ebb57652e/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/extendable-event-waituntil.https-expected.txt
[modify] https://crrev.com/06f33f6fa8d71e31838103a0e12f95e8420510d2/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/06f33f6fa8d71e31838103a0e12f95e8420510d2/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h
[modify] https://crrev.com/06f33f6fa8d71e31838103a0e12f95e8420510d2/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Comment 3 by falken@chromium.org, May 12 2017

Labels: M-60
Status: Fixed (was: Assigned)
Thanks for filing and fixing!
Cc: falken@chromium.org
 Issue 709591  has been merged into this issue.

Sign in to add a comment