New issue
Advanced search Search tips

Issue 719848 link

Starred by 2 users
Status: Fixed
Owner:
robertphillips@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

MSAN bot failure (read uninitialized value) since skia roll

Project Member Reported by yutak@chromium.org, May 9 2017 
MSAN bot started to fail since the following skia roll.

Bot:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN

Skia roll:
https://chromium.googlesource.com/chromium/src/+/b0433ed2c9ef88bec875e676b03e861ee6a1b601

Failure log:
21:38:47.947 8787 worker/7 virtual/gpu-rasterization/images/12-55.html crashed, (stderr lines):
21:38:47.947 8787   ==1==WARNING: MemorySanitizer: use-of-uninitialized-value
21:38:47.947 8787       #0 0x82bd375 in GrPipeline::AreEqual(GrPipeline const&, GrPipeline const&) third_party/skia/src/gpu/GrPipeline.cpp:129:9
21:38:47.947 8787       #1 0x7a674bd in CanCombine third_party/skia/src/gpu/GrPipeline.h:122:14
21:38:47.947 8787       #2 0x7a674bd in AAFillRectOp::onCombineIfPossible(GrOp*, GrCaps const&) third_party/skia/src/gpu/ops/GrAAFillRectOp.cpp:265:0
21:38:47.947 8787       #3 0x79fd8e9 in combineIfPossible third_party/skia/src/gpu/ops/GrOp.h:73:22
21:38:47.947 8787       #4 0x79fd8e9 in combineIfPossible third_party/skia/src/gpu/GrRenderTargetOpList.cpp:290:0
21:38:47.947 8787       #5 0x79fd8e9 in GrRenderTargetOpList::recordOp(std::__1::unique_ptr<GrOp, std::__1::default_delete<GrOp> >, GrRenderTargetContext*, GrAppliedClip*, GrXferProcessor::DstTexture const*) third_party/skia/src/gpu/GrRenderTargetOpList.cpp:336:0
21:38:47.947 8787       #6 0x79d57b3 in addOp third_party/skia/src/gpu/GrRenderTargetOpList.h:69:15
21:38:47.947 8787       #7 0x79d57b3 in GrRenderTargetContext::addLegacyMeshDrawOp(GrPipelineBuilder&&, GrClip const&, std::__1::unique_ptr<GrLegacyMeshDrawOp, std::__1::default_delete<GrLegacyMeshDrawOp> >) third_party/skia/src/gpu/GrRenderTargetContext.cpp:1684:0
21:38:47.947 8787       #8 0x79dcc01 in GrRenderTargetContext::fillRectToRect(GrClip const&, GrPaint&&, GrAA, SkMatrix const&, SkRect const&, SkRect const&) third_party/skia/src/gpu/GrRenderTargetContext.cpp:762:15
21:38:47.947 8787       #9 0x7d18b3b in SkGpuDevice::drawTextureProducerImpl(GrTextureProducer*, SkRect const&, SkRect const&, SkCanvas::SrcRectConstraint, SkMatrix const&, SkMatrix const&, GrClip const&, SkPaint const&) third_party/skia/src/gpu/SkGpuDevice_drawTexture.cpp:218:31
21:38:47.947 8787       #10 0x7d17030 in SkGpuDevice::drawTextureProducer(GrTextureProducer*, SkRect const*, SkRect const*, SkCanvas::SrcRectConstraint, SkMatrix const&, GrClip const&, SkPaint const&) third_party/skia/src/gpu/SkGpuDevice_drawTexture.cpp:143:11
21:38:47.947 8787       #11 0x7d05c0f in SkGpuDevice::drawImageRect(SkImage const*, SkRect const*, SkRect const&, SkPaint const&, SkCanvas::SrcRectConstraint) third_party/skia/src/gpu/SkGpuDevice.cpp:1406:15
21:38:47.948 8787       #12 0x7496e7c in SkCanvas::onDrawImageRect(SkImage const*, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::SrcRectConstraint) third_party/skia/src/core/SkCanvas.cpp:2232:23
21:38:47.948 8787       #13 0x12f6310b in SkNWayCanvas::onDrawImageRect(SkImage const*, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::SrcRectConstraint) third_party/skia/src/utils/SkNWayCanvas.cpp:225:15
21:38:47.948 8787       #14 0xa63ffad in cc::ImageHijackCanvas::onDrawImageRect(SkImage const*, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::SrcRectConstraint) cc/raster/image_hijack_canvas.cc:244:17
21:38:47.948 8787       #15 0x8700f00 in Raster cc/paint/paint_op_buffer.cc:444:3
21:38:47.948 8787       #16 0x8700f00 in cc::PaintOpBuffer::playback(SkCanvas*) const cc/paint/paint_op_buffer.cc:638:0
21:38:47.948 8787       #17 0x8703fa6 in cc::PaintOpBuffer::playback(SkCanvas*, SkPicture::AbortCallback*) const cc/paint/paint_op_buffer.cc:648:5
21:38:47.948 8787       #18 0x86f6295 in cc::(anonymous namespace)::RasterItem(cc::DisplayItem const&, SkCanvas*, SkPicture::AbortCallback*) cc/paint/display_item_list.cc:109:21
21:38:47.948 8787       #19 0x86f536e in cc::DisplayItemList::Raster(SkCanvas*, SkPicture::AbortCallback*) const cc/paint/display_item_list.cc:245:5
21:38:47.948 8787       #20 0xa4ac0a7 in RasterCommon cc/raster/raster_source.cc:218:20
21:38:47.948 8787       #21 0xa4ac0a7 in cc::RasterSource::PlaybackToCanvas(SkCanvas*, gfx::ColorSpace const&, cc::RasterSource::PlaybackSettings const&) const cc/raster/raster_source.cc:118:0
21:38:47.948 8787       #22 0xa4ab3ae in cc::RasterSource::PlaybackToCanvas(SkCanvas*, gfx::ColorSpace const&, gfx::Rect const&, gfx::Rect const&, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) const cc/raster/raster_source.cc:84:3
21:38:47.948 8787       #23 0xa4a001d in RasterizeSource cc/raster/gpu_raster_buffer_provider.cc:80:18
21:38:47.948 8787       #24 0xa4a001d in cc::GpuRasterBufferProvider::PlaybackOnWorkerThread(cc::ResourceProvider::ScopedWriteLockGL*, gpu::SyncToken const&, bool, cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, unsigned long, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) cc/raster/gpu_raster_buffer_provider.cc:270:0
21:38:47.948 8787       #25 0xa49f1d1 in cc::GpuRasterBufferProvider::RasterBufferImpl::Playback(cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, unsigned long, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) cc/raster/gpu_raster_buffer_provider.cc:111:12
21:38:47.948 8787       #26 0xa5ed15f in cc::(anonymous namespace)::RasterTaskImpl::RunOnWorkerThread() cc/tiles/tile_manager.cc:130:21
21:38:47.948 8787       #27 0xa4c54a2 in cc::SynchronousTaskGraphRunner::RunTask() cc/raster/synchronous_task_graph_runner.cc:91:26
21:38:47.948 8787       #28 0xa4c620c in cc::SynchronousTaskGraphRunner::RunUntilIdle() cc/raster/synchronous_task_graph_runner.cc:65:10
21:38:47.948 8787       #29 0xa4232f9 in cc::SingleThreadProxy::CompositeImmediately(base::TimeTicks) cc/trees/single_thread_proxy.cc:498:28
21:38:47.948 8787       #30 0x69f8b75 in Run base/callback.h:91:12
21:38:47.948 8787       #31 0x69f8b75 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0
21:38:47.948 8787       #32 0xc3a3628 in blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow, base::TimeTicks*) third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:531:19
21:38:47.948 8787       #33 0xc39ae46 in blink::scheduler::TaskQueueManager::DoWork(bool) third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:329:13
21:38:47.948 8787       #34 0x69f8b75 in Run base/callback.h:91:12
21:38:47.948 8787       #35 0x69f8b75 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0
21:38:47.948 8787       #36 0x67bd1c3 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:404:19
21:38:47.948 8787       #37 0x67beb4b in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:415:5
21:38:47.948 8787       #38 0x67bf79e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:503:13
21:38:47.948 8787       #39 0x67cbd4a in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31
21:38:47.948 8787       #40 0x6853938 in base::RunLoop::Run() base/run_loop.cc:105:10
21:38:47.948 8787       #41 0x11c015fe in content::RendererMain(content::MainFunctionParams const&) content/renderer/renderer_main.cc:200:23
21:38:47.948 8787       #42 0x471a663 in content::RunZygote(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:341:14
21:38:47.948 8787       #43 0x471d13e in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:420:12
21:38:47.948 8787       #44 0x471fe3b in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:705:12
21:38:47.948 8787       #45 0xaed3c04 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:455:29
21:38:47.948 8787       #46 0x135465e in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10
21:38:47.949 8787       #47 0x4b180f in main content/shell/app/shell_main.cc:48:10
21:38:47.949 8787       #48 0x7f2d22f5df44 in __libc_start_main /build/eglibc-MjiXCM/eglibc-2.19/csu/libc-start.c:287:0
21:38:47.949 8787       #49 0x441f35 in _start ??:0:0
21:38:47.949 8787
21:38:47.949 8787     Uninitialized value was created by a heap allocation
21:38:47.949 8787       #0 0x4685ed in __interceptor_malloc ??:0:0
21:38:47.949 8787       #1 0x7423ff6 in sk_malloc_throw(unsigned long) skia/ext/SkMemory_new_handler.cpp:64:66
21:38:47.949 8787       #2 0x79b17a1 in CreateBlock third_party/skia/src/gpu/GrMemoryPool.cpp:143:40
21:38:47.949 8787       #3 0x79b17a1 in GrMemoryPool::GrMemoryPool(unsigned long, unsigned long) third_party/skia/src/gpu/GrMemoryPool.cpp:32:0
21:38:47.949 8787       #4 0x7afa0cd in pool third_party/skia/src/gpu/ops/GrOp.cpp:37:29
21:38:47.949 8787       #5 0x7afa0cd in GrOp::operator new(unsigned long) third_party/skia/src/gpu/ops/GrOp.cpp:48:0
21:38:47.949 8787       #6 0x7ae5cf8 in std::__1::unique_ptr<GrDrawOp, std::__1::default_delete<GrDrawOp> > GrSimpleMeshDrawOpHelper::FactoryHelper<NewNonAAFillRectOp, SkMatrix, SkRect, SkRect const*, SkMatrix const*, GrAAType, GrUserStencilSettings const*>(GrPaint&&, SkMatrix, SkRect, SkRect const*, SkMatrix const*, GrAAType, GrUserStencilSettings const*) third_party/skia/src/gpu/ops/GrSimpleMeshDrawOpHelper.h:201:28
21:38:47.949 8787       #7 0x7ae560e in FactoryHelper<NewNonAAFillRectOp, SkMatrix, SkRect, const SkRect *, const SkMatrix *, GrAAType, const GrUserStencilSettings *> third_party/skia/src/gpu/ops/GrSimpleMeshDrawOpHelper.h:154:16
21:38:47.949 8787       #8 0x7ae560e in Make third_party/skia/src/gpu/ops/GrNewNonAAFillRectOp.cpp:83:0
21:38:47.949 8787       #9 0x7ae560e in GrNewNonAAFillRectOp::Make(GrPaint&&, SkMatrix const&, SkRect const&, SkRect const*, SkMatrix const*, GrAAType, GrUserStencilSettings const*) third_party/skia/src/gpu/ops/GrNewNonAAFillRectOp.cpp:193:0
21:38:47.949 8787       #10 0x79c84d3 in GrRenderTargetContext::drawNonAAFilledRect(GrClip const&, GrPaint&&, SkMatrix const&, SkRect const&, SkRect const*, SkMatrix const*, GrUserStencilSettings const*, GrAAType) third_party/skia/src/gpu/GrRenderTargetContext.cpp:1278:40
21:38:47.949 8787       #11 0x79d0c1c in GrRenderTargetContext::drawFilledRect(GrClip const&, GrPaint&&, GrAA, SkMatrix const&, SkRect const&, GrUserStencilSettings const*) third_party/skia/src/gpu/GrRenderTargetContext.cpp:465:15
21:38:47.949 8787       #12 0x79cb060 in GrRenderTargetContext::drawRect(GrClip const&, GrPaint&&, GrAA, SkMatrix const&, SkRect const&, GrStyle const*) third_party/skia/src/gpu/GrRenderTargetContext.cpp:522:19
21:38:47.949 8787       #13 0x79ce963 in GrRenderTargetContext::drawPaint(GrClip const&, GrPaint&&, SkMatrix const&) third_party/skia/src/gpu/GrRenderTargetContext.cpp:357:15
21:38:47.949 8787       #14 0x7ce33cb in SkGpuDevice::drawPaint(SkPaint const&) third_party/skia/src/gpu/SkGpuDevice.cpp:288:27
21:38:47.949 8787       #15 0x748997d in SkCanvas::internalDrawPaint(SkPaint const&) third_party/skia/src/core/SkCanvas.cpp:1931:23
21:38:47.949 8787       #16 0x74890cb in SkCanvas::onDrawPaint(SkPaint const&) third_party/skia/src/core/SkCanvas.cpp:1924:11
21:38:47.949 8787       #17 0x74a9f8f in drawPaint third_party/skia/src/core/SkCanvas.cpp:1710:11
21:38:47.949 8787       #18 0x74a9f8f in SkCanvas::drawColor(unsigned int, SkBlendMode) third_party/skia/src/core/SkCanvas.cpp:2704:0
21:38:47.949 8787       #19 0xa4ad302 in clear third_party/skia/include/core/SkCanvas.h:557:15
21:38:47.949 8787       #20 0xa4ad302 in cc::RasterSource::PrepareForPlaybackToCanvas(SkCanvas*) const cc/raster/raster_source.cc:209:0
21:38:47.949 8787       #21 0xa4abaeb in cc::RasterSource::PlaybackToCanvas(SkCanvas*, gfx::ColorSpace const&, cc::RasterSource::PlaybackSettings const&) const cc/raster/raster_source.cc:100:5
21:38:47.949 8787       #22 0xa4ab3ae in cc::RasterSource::PlaybackToCanvas(SkCanvas*, gfx::ColorSpace const&, gfx::Rect const&, gfx::Rect const&, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) const cc/raster/raster_source.cc:84:3
21:38:47.949 8787       #23 0xa4a001d in RasterizeSource cc/raster/gpu_raster_buffer_provider.cc:80:18
21:38:47.949 8787       #24 0xa4a001d in cc::GpuRasterBufferProvider::PlaybackOnWorkerThread(cc::ResourceProvider::ScopedWriteLockGL*, gpu::SyncToken const&, bool, cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, unsigned long, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) cc/raster/gpu_raster_buffer_provider.cc:270:0
21:38:47.949 8787       #25 0xa49f1d1 in cc::GpuRasterBufferProvider::RasterBufferImpl::Playback(cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, unsigned long, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) cc/raster/gpu_raster_buffer_provider.cc:111:12
21:38:47.949 8787       #26 0xa5ed15f in cc::(anonymous namespace)::RasterTaskImpl::RunOnWorkerThread() cc/tiles/tile_manager.cc:130:21
21:38:47.949 8787
21:38:47.949 8787   SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/c/b/linux_layout/src/out/Release/content_shell+0x82bd375)
21:38:47.949 8787   Exiting

Comment 1 by yutak@chromium.org, May 9 2017 

I will revert the skia rolls up to the offending one. (Auto roller is already
stopped.)
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12dd72e2ea6a81907434ec2192ffc25e85de4db9

commit 12dd72e2ea6a81907434ec2192ffc25e85de4db9
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue May 09 07:11:00 2017

Revert "Roll src/third_party/skia/ 892af1ec7..d2da87d0b (6 commits; 1 trivial rolls)"

This reverts commit 9c828809572ffb748f5b3139734f8b9e0d398f04.

Reason for revert: To fix the MSAN bot failure (see  bug 719848 ).

BUG= 719848 

Original change's description:
> Roll src/third_party/skia/ 892af1ec7..d2da87d0b (6 commits; 1 trivial rolls)
> 
> https://skia.googlesource.com/skia.git/+log/892af1ec7bb0..d2da87d0b8d1
> 
> $ git log 892af1ec7..d2da87d0b --date=short --no-merges --format='%ad %ae %s'
> 2017-05-08 brianosman Forward getGrContext in color space xform canvas
> 2017-05-08 reed remove (possibly slow) call to refEncoded in getDeferredTextureImageData
> 2017-05-08 herb Add radial gradient stage.
> 2017-05-08 egdaniel Implement disconnect function for GrVkGpu
> 2017-05-08 ethannicholas Minor sksl parser cleanup
> 
> Created with:
>   roll-dep src/third_party/skia
> 
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> TBR=stani@chromium.org
> 
> Change-Id: Idecbc541a80f5f4587974b8f8372e286faae8ac4
> Reviewed-on: https://chromium-review.googlesource.com/499688
> Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#470243}

TBR=skia-deps-roller@chromium.org,stani@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Ie88bdfce88a65119d065e725911f2edf366cc05f
Reviewed-on: https://chromium-review.googlesource.com/500107
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470258}
[modify] https://crrev.com/12dd72e2ea6a81907434ec2192ffc25e85de4db9/DEPS
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aca5f54a145121f5dc81ad0c282ac05caba07f06

commit aca5f54a145121f5dc81ad0c282ac05caba07f06
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue May 09 07:13:40 2017

Revert "Roll src/third_party/skia/ 05814de6b..892af1ec7 (27 commits)"

This reverts commit b0433ed2c9ef88bec875e676b03e861ee6a1b601.

Reason for revert: To fix the MSAN bot failure ( issue 719848 )

BUG= 719848 

Original change's description:
> Roll src/third_party/skia/ 05814de6b..892af1ec7 (27 commits)
> 
> https://skia.googlesource.com/skia.git/+log/05814de6ba50..892af1ec7bb0
> 
> $ git log 05814de6b..892af1ec7 --date=short --no-merges --format='%ad %ae %s'
> 2017-05-08 mtklein add a guide to contributing to SkJumper
> 2017-05-08 bsalomon Revert "Added SkImage::MakeCrossContextFromEncoded"
> 2017-05-08 ethannicholas fixed InstanceProcessor SkSL code
> 2017-05-08 mtklein "can we?" -> "do we want to?" for SkRasterPipelineBlitter
> 2017-05-08 brianosman Added SkImage::MakeCrossContextFromEncoded
> 2017-05-08 update-skps Update SKP version
> 2017-05-08 halcanary SkAdvancedTypefaceMetrics: pack fields better
> 2017-05-08 mtklein fix commented-out gaussian
> 2017-05-08 jvanverth Remove height functor for shadows and replace with plane equation params
> 2017-05-08 csmartdalton vk: don't re-check the primitive type for each batch of a mesh
> 2017-05-08 robertphillips Revert "Revert "Re-enable deferred proxies in Chrome""
> 2017-05-08 robertphillips Expand GrTextureProxy to handle highestFilterMode
> 2017-05-08 fmalita Minimize computeTotalInverse()'s inputs
> 2017-05-05 csmartdalton GL: track enabled vertex arrays as a count rather than a mask
> 2017-05-07 mtklein port ok to SkPngEncoder
> 2017-05-08 rmistry Separate lines added via post upload from original description
> 2017-05-08 bsalomon Update minimum non-ES OpenGL spec to 2.0.
> 2017-05-08 bsalomon Remove support for GLs without separate stencil.
> 2017-05-08 msarett Add filtering and zlib-level options to SkPngEncoder
> 2017-05-08 rmistry Revert "Presubmit: ensure empty line between CL title and description"
> 2017-05-08 ethannicholas Re-land of "eliminated GrGLSLExpr".
> 2017-05-08 brianosman Allow wrapped resources to have unique keys
> 2017-05-08 benjaminwagner [Bazel] Omit bigrect GM for ASAN.
> 2017-05-05 senorblanco GrTessellator AA: fix 1px wide paths.
> 2017-05-08 fmalita Remove Sk4fGradientInterval::fZeroRamp
> 2017-05-08 brianosman SkImage::isValid
> 2017-05-04 mtklein jumper, finish blend modes
> 
> Created with:
>   roll-dep src/third_party/skia
> 
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, see:
> http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> TBR=stani@chromium.org
> 
> Change-Id: Ib24fdc7c5561440520b0193bbe827a4cabb2012d
> Reviewed-on: https://chromium-review.googlesource.com/499568
> Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#470155}

TBR=skia-deps-roller@chromium.org,stani@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I8824a3c2635c593062e88f52b7e7ba3ecff3a6de
Reviewed-on: https://chromium-review.googlesource.com/500108
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470259}
[modify] https://crrev.com/aca5f54a145121f5dc81ad0c282ac05caba07f06/DEPS

Comment 4 by yutak@chromium.org, May 9 2017

Labels: Sheriff-Chromium
Reverted the rolls. Watching the tree status now.

Comment 5 by robertphillips@chromium.org, May 9 2017 

The Skia CL: https://skia-review.googlesource.com/c/16101/ (Remove 'fDrawFace' from GrPipeline) should fix the MSAN issue.

I have landed that CL and restarted Skia's auto-roll bot.

Comment 6 by olka@chromium.org, May 9 2017

Labels: -Sheriff-Chromium
Bots are all green after revert, removing sheriff label.

Comment 7 by yutak@chromium.org, May 12 2017

Owner: robertphillips@chromium.org
Status: Fixed (was: Available)
Thanks, marking this fixed.
►

Sign in to add a comment