inspector/sources/debugger/rethrow-error-from-bindings-crash.html timing out on debug after V8 6.0.181 |
|||||||
Issue descriptionThe following test started to time out on debug bots after V8 roll to v6.0.181. I manually reproduced and confirmed that V8 roll was the offender. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=inspector%2Fsources%2Fdebugger%2Frethrow-error-from-bindings-crash.html V8 roll: https://chromium.googlesource.com/chromium/src/+/3b2a2acc04df20808235a2ef415f04290c80a383 This only manifests on debug bots. The test ran in ~30 seconds previously, but the V8 roll made the test much slower (or hang). I will add a test expectation for this.
,
May 9 2017
,
May 9 2017
,
May 10 2017
The test is still failing in release builds: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/440757
,
May 10 2017
,
May 10 2017
,
May 10 2017
kozy, could you have a look? There are not many interesting CLs in the roll https://codereview.chromium.org/2869723005/, except maybe: https://chromium.googlesource.com/v8/v8/+/d2ba280d47bf6250aca27b1997c28dce3d0d2963 or https://chromium.googlesource.com/v8/v8/+/918c23643bbd025a7915cdd7961e6f82cbdc8cb2 Please rather skip the test in release as well rather than reverting the roll. I assume the release bots in CQ have dchecks on, which means DEBUG V8 under the hood.
,
May 10 2017
There are a bunch of other failing tests, see issue 720511 . The chromium CQ is pretty much broken due to this at the moment. Reverting is simpler.
,
May 10 2017
Mentioned test was broken by: https://chromium.googlesource.com/v8/v8/+/918c23643bbd025a7915cdd7961e6f82cbdc8cb2. Fix landed and will be rolled to chromium soon: https://chromium-review.googlesource.com/c/501351/ I'll mark this as fixed after rolling.
,
May 10 2017
Can we force this fix to be merged faster then regular V8 rolling?
,
May 10 2017
Is this also the culprit for issue 720511 ?
,
May 10 2017
For now V8 is reverted to an old version here: https://codereview.chromium.org/2868373002/ We should then attempt to roll behind the v8 side revert, in case it's enough for both bugs.
,
May 10 2017
Rolling is somewhat broken by http://crbug.com/720223 You can roll manually by setting the lkgr, kicking off a build here https://uberchromegw.corp.google.com/i/client.v8.fyi/builders/V8%20lkgr%20finder filling the revision field with the v8 revision that should become the new lkgr. When rolling is open in the status app, and no current roll CL is open, the auto-rollers will pick up the revision.
,
May 10 2017
#11, I'm currently checking locally. I need probably 10 more minutes.
,
May 10 2017
Ok, I'll try to roll after checking locally and revert landed.
,
May 10 2017
Take your time. Lets let V8 get reverted in piece and then re-roll... though, I'll be logging off now.
,
May 15 2017
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/427b578e15e154e18302949386250d298c432d5f commit 427b578e15e154e18302949386250d298c432d5f Author: Jochen Eisinger <jochen@chromium.org> Date: Mon May 15 08:23:48 2017 Unskip inspector test after V8 side was fixed BUG= 719837 TBR=machenbach@chromium.org Change-Id: I4f2edddbd66aa61621e91ad52e74d4f58c3083f7 Reviewed-on: https://chromium-review.googlesource.com/506007 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#471692} [modify] https://crrev.com/427b578e15e154e18302949386250d298c432d5f/third_party/WebKit/LayoutTests/TestExpectations |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, May 9 2017