Allow tests to simulate advertisements as well as responses for scanning operations e.g. start scan succeeded.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7eba85ba4a8dd6fce696dc4b6ae70be0f79b4e3 commit a7eba85ba4a8dd6fce696dc4b6ae70be0f79b4e3 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Thu Mar 01 19:02:15 2018 bluetooth: web: test: Simulate advertisements This change adds a SimulateAdvertisementReceived function to the FakeCentral interface. The design for this class is detailed in the following document: https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg BUG=719826 Change-Id: I618dc68c967e6d9942f99f1807da6fb1985cd676 Reviewed-on: https://chromium-review.googlesource.com/916554 Reviewed-by: Oliver Chang <ochang@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#540236} [modify] https://crrev.com/a7eba85ba4a8dd6fce696dc4b6ae70be0f79b4e3/device/bluetooth/public/mojom/test/fake_bluetooth.mojom [modify] https://crrev.com/a7eba85ba4a8dd6fce696dc4b6ae70be0f79b4e3/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/a7eba85ba4a8dd6fce696dc4b6ae70be0f79b4e3/device/bluetooth/test/fake_central.h [add] https://crrev.com/a7eba85ba4a8dd6fce696dc4b6ae70be0f79b4e3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html [modify] https://crrev.com/a7eba85ba4a8dd6fce696dc4b6ae70be0f79b4e3/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth.mojom.js [modify] https://crrev.com/a7eba85ba4a8dd6fce696dc4b6ae70be0f79b4e3/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/327e84d34a0f1699bf72b4006c7944a0a0906b70 commit 327e84d34a0f1699bf72b4006c7944a0a0906b70 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Thu Mar 01 21:18:22 2018 bluetooth: Allow variable test scan duration This change enables the scan duration to be set for a test. This enables tests to have the ability to manipulate events during a scan. The purpose for this change is to implement a scanning API for Web Bluetooth Tests. The design for this API is found in the following document: https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg BUG=719826 Change-Id: I6e060ee8d4d149134331c983a9cb884d9ae557f5 Reviewed-on: https://chromium-review.googlesource.com/930123 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#540287} [modify] https://crrev.com/327e84d34a0f1699bf72b4006c7944a0a0906b70/content/browser/bluetooth/bluetooth_device_chooser_controller.cc [modify] https://crrev.com/327e84d34a0f1699bf72b4006c7944a0a0906b70/content/browser/bluetooth/bluetooth_device_chooser_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af1c15b16f99d290799c83d34c111bce52447026 commit af1c15b16f99d290799c83d34c111bce52447026 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Wed Mar 07 21:05:22 2018 bluetooth: Use DeviceUUID in FakeBluetooth This change refactors the Web Bluetooth test API to use the DeviceUUIDs helper class defined in BluetoothDevice. Additionally, this change finishes the implementation of SimulateGATTServicesChanged, and as a result, tests are updated to set the next discovery response before calling this interface. BUG=719826 Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d Reviewed-on: https://chromium-review.googlesource.com/939984 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541577} [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/device/bluetooth/test/fake_peripheral.cc [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/device/bluetooth/test/fake_peripheral.h [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptor/gen-characteristic-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptor/gen-service-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed-with-uuid.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptors/gen-service-is-removed-with-uuid.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptors/gen-service-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/notifications/service-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/readValue/gen-characteristic-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/readValue/service-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/startNotifications/gen-characteristic-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/writeValue/gen-characteristic-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/writeValue/service-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/descriptor/readValue/gen-service-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/descriptor/writeValue/gen-service-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/script-tests/characteristic/characteristic-is-removed.js [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/script-tests/characteristic/service-is-removed.js [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/script-tests/descriptor/service-is-removed.js [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/script-tests/service/service-is-removed.js [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/service/getCharacteristic/gen-service-is-removed.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/service/getCharacteristics/gen-service-is-removed-with-uuid.https.html [modify] https://crrev.com/af1c15b16f99d290799c83d34c111bce52447026/third_party/WebKit/LayoutTests/external/wpt/bluetooth/service/getCharacteristics/gen-service-is-removed.https.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f193d0287c82d2ebf589556493d134fde9edefde commit f193d0287c82d2ebf589556493d134fde9edefde Author: Ovidio Henriquez <odejesush@chromium.org> Date: Sat Mar 10 06:22:22 2018 bluetooth: Add discovery sessions to FakeCentral This change adds discovery session support to FakeCentral in order to allow Bluetooth scanning to be simulated. BUG=719826,719827 Change-Id: Ia5150cc14924e9e03e5361797068db6718b26595 Reviewed-on: https://chromium-review.googlesource.com/954231 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#542349} [modify] https://crrev.com/f193d0287c82d2ebf589556493d134fde9edefde/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/f193d0287c82d2ebf589556493d134fde9edefde/device/bluetooth/test/fake_central.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9cedccbf5d463f454ada627e030cf5710d1462c commit f9cedccbf5d463f454ada627e030cf5710d1462c Author: Trent Apted <tapted@chromium.org> Date: Mon Mar 12 03:50:21 2018 Revert "bluetooth: Use DeviceUUID in FakeBluetooth" This reverts commit af1c15b16f99d290799c83d34c111bce52447026. Reason for revert: suspected for persistent failures on Win7 Tests (dbg)(1) Unexpected Failures: * external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html * external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html * external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html * external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html * external/wpt/upgrade-insecure-requests/link-upgrade.sub.https.html since https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66761 errors like 15:59:42.310 5904 worker/4 external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html crashed, (stderr lines): 15:59:42.311 5904 CONSOLE MESSAGE: line 255: Web Bluetooth is experimental on this platform. See https://github.com/WebBluetoothCG/web-bluetooth/blob/gh-pages/implementation-status.md 15:59:42.327 1300 [1691/5755] external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html failed unexpectedly (content_shell crashed [pid=5644]) Original change's description: > bluetooth: Use DeviceUUID in FakeBluetooth > > This change refactors the Web Bluetooth test API to use the > DeviceUUIDs helper class defined in BluetoothDevice. Additionally, > this change finishes the implementation of SimulateGATTServicesChanged, > and as a result, tests are updated to set the next discovery response > before calling this interface. > > BUG=719826 > > Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d > Reviewed-on: https://chromium-review.googlesource.com/939984 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541577} TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 719826 Change-Id: I02bb7066c6f1282191f7a24e91b3d2c5614b8104 Reviewed-on: https://chromium-review.googlesource.com/958741 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542421} [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/device/bluetooth/test/fake_peripheral.cc [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/device/bluetooth/test/fake_peripheral.h [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptor/gen-characteristic-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptor/gen-service-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed-with-uuid.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptors/gen-service-is-removed-with-uuid.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/getDescriptors/gen-service-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/notifications/service-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/readValue/gen-characteristic-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/readValue/service-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/startNotifications/gen-characteristic-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/writeValue/gen-characteristic-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/characteristic/writeValue/service-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/descriptor/readValue/gen-service-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/descriptor/writeValue/gen-service-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/script-tests/characteristic/characteristic-is-removed.js [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/script-tests/characteristic/service-is-removed.js [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/script-tests/descriptor/service-is-removed.js [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/script-tests/service/service-is-removed.js [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/service/getCharacteristic/gen-service-is-removed.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/service/getCharacteristics/gen-service-is-removed-with-uuid.https.html [modify] https://crrev.com/f9cedccbf5d463f454ada627e030cf5710d1462c/third_party/WebKit/LayoutTests/external/wpt/bluetooth/service/getCharacteristics/gen-service-is-removed.https.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20d09354e647316c4c51ab94ab63c18024f791dc commit 20d09354e647316c4c51ab94ab63c18024f791dc Author: Ovidio Henriquez <odejesush@chromium.org> Date: Tue Mar 20 00:49:03 2018 bluetooth: Use DeviceUUID in FakePeripheral This change refactors FakePeripheral to use the built-in DeviceUUIDs helper class in BluetoothDevice to handle the UUIDs for a device. BUG=719826 Change-Id: I9c60f00912aca706f16f402031483711f6f3ae89 Reviewed-on: https://chromium-review.googlesource.com/958337 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#544235} [modify] https://crrev.com/20d09354e647316c4c51ab94ab63c18024f791dc/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/20d09354e647316c4c51ab94ab63c18024f791dc/device/bluetooth/test/fake_peripheral.cc [modify] https://crrev.com/20d09354e647316c4c51ab94ab63c18024f791dc/device/bluetooth/test/fake_peripheral.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/105a98d1bc948e5bd62a978d58d70c1b465c28c4 commit 105a98d1bc948e5bd62a978d58d70c1b465c28c4 Author: Christos Froussios <cfroussios@chromium.org> Date: Thu Mar 22 12:00:14 2018 Revert "bluetooth: Use DeviceUUID in FakePeripheral" This reverts commit 20d09354e647316c4c51ab94ab63c18024f791dc. Reason for revert: Suspected of breaking * external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html * external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html * external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html * external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html Original change's description: > bluetooth: Use DeviceUUID in FakePeripheral > > This change refactors FakePeripheral to use the built-in DeviceUUIDs > helper class in BluetoothDevice to handle the UUIDs for a device. > > BUG=719826 > > Change-Id: I9c60f00912aca706f16f402031483711f6f3ae89 > Reviewed-on: https://chromium-review.googlesource.com/958337 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Conley Owens <cco3@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544235} TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 719826, 824704 Change-Id: I4543474f7412f954fe062c06d05a458cdf6d6447 Reviewed-on: https://chromium-review.googlesource.com/975123 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#545043} [modify] https://crrev.com/105a98d1bc948e5bd62a978d58d70c1b465c28c4/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/105a98d1bc948e5bd62a978d58d70c1b465c28c4/device/bluetooth/test/fake_peripheral.cc [modify] https://crrev.com/105a98d1bc948e5bd62a978d58d70c1b465c28c4/device/bluetooth/test/fake_peripheral.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7 commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Wed Mar 28 16:07:28 2018 bluetooth: FakeBluetoothChooser impl. Implements the interfaces that FakeBluetoothChooser overrides. The mojom::FakeBluetoothChooser overrides are implemented by running |event_handler_| with the appropriate arguments. The BluetoothChooser overrides do nothing at the moment, since the base class is only meant to update the chooser user interface. This change also begins to partially convert a Bluetooth chooser test to test the interface and deletes the temporary tests that were created to test this API. BUG=719827,719826, 824704 Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3 Reviewed-on: https://chromium-review.googlesource.com/962983 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#546509} [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/content/shell/browser/layout_test/fake_bluetooth_chooser.cc [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/content/shell/browser/layout_test/fake_bluetooth_chooser.h [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/content/shell/common/layout_test/fake_bluetooth_chooser.mojom [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/device/bluetooth/test/fake_peripheral.cc [delete] https://crrev.com/796a52c1d07285b09a47bad7049ecaafcfb40aa0/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html [delete] https://crrev.com/796a52c1d07285b09a47bad7049ecaafcfb40aa0/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js [modify] https://crrev.com/188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42624492cd5e80855f1dd3a5a8146b258def2c2a commit 42624492cd5e80855f1dd3a5a8146b258def2c2a Author: François Doray <fdoray@chromium.org> Date: Wed Mar 28 19:48:22 2018 Revert "bluetooth: FakeBluetoothChooser impl." This reverts commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7. Reason for revert: https://crbug.com/826787 Original change's description: > bluetooth: FakeBluetoothChooser impl. > > Implements the interfaces that FakeBluetoothChooser overrides. The > mojom::FakeBluetoothChooser overrides are implemented by running > |event_handler_| with the appropriate arguments. The BluetoothChooser > overrides do nothing at the moment, since the base class is only meant > to update the chooser user interface. > > This change also begins to partially convert a Bluetooth chooser test to test > the interface and deletes the temporary tests that were created to test this > API. > > BUG=719827,719826, 824704 > > Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3 > Reviewed-on: https://chromium-review.googlesource.com/962983 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Conley Owens <cco3@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546509} TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org Change-Id: I0597151ec5878d41ac631b72296203bc99b1f2c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 719827, 719826, 824704 , 826787 Reviewed-on: https://chromium-review.googlesource.com/984299 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#546572} [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/browser/layout_test/fake_bluetooth_chooser.cc [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/browser/layout_test/fake_bluetooth_chooser.h [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/content/shell/common/layout_test/fake_bluetooth_chooser.mojom [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/device/bluetooth/test/fake_peripheral.cc [add] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html [add] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js [modify] https://crrev.com/42624492cd5e80855f1dd3a5a8146b258def2c2a/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a337f19713e049cd42969b0c909c59aff4146cd commit 6a337f19713e049cd42969b0c909c59aff4146cd Author: Ovidio Henriquez <odejesush@chromium.org> Date: Thu Mar 29 05:16:26 2018 bluetooth: FakeBluetoothChooser impl. Implements the interfaces that FakeBluetoothChooser overrides. The mojom::FakeBluetoothChooser overrides are implemented by running |event_handler_| with the appropriate arguments. The BluetoothChooser overrides do nothing at the moment, since the base class is only meant to update the chooser user interface. This change also begins to partially convert a Bluetooth chooser test to test the interface and deletes the temporary tests that were created to test this API. This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which reverted the original change. The original change caused the new-scan-device-added.html test to fail because of a Mojo validation error resulting from not updating the third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js file needed by the test. Bug: 719827, 719826, 824704 , 826787 Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 Reviewed-on: https://chromium-review.googlesource.com/985195 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#546729} [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/browser/layout_test/fake_bluetooth_chooser.cc [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/browser/layout_test/fake_bluetooth_chooser.h [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/content/shell/common/layout_test/fake_bluetooth_chooser.mojom [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/device/bluetooth/test/fake_peripheral.cc [delete] https://crrev.com/fad0f0ae8508c3df9a7eed21de48065117c7a753/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html [delete] https://crrev.com/fad0f0ae8508c3df9a7eed21de48065117c7a753/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js [modify] https://crrev.com/6a337f19713e049cd42969b0c909c59aff4146cd/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d04a1e5256a9fdd78f40cbdb73355408614e14f3 commit d04a1e5256a9fdd78f40cbdb73355408614e14f3 Author: François Doray <fdoray@chromium.org> Date: Thu Mar 29 16:27:57 2018 Revert "bluetooth: FakeBluetoothChooser impl." This reverts commit 6a337f19713e049cd42969b0c909c59aff4146cd. Reason for revert: https://crbug.com/824704 These tests are failing: external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.https.html external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html Original change's description: > bluetooth: FakeBluetoothChooser impl. > > Implements the interfaces that FakeBluetoothChooser overrides. The > mojom::FakeBluetoothChooser overrides are implemented by running > |event_handler_| with the appropriate arguments. The BluetoothChooser > overrides do nothing at the moment, since the base class is only meant > to update the chooser user interface. > > This change also begins to partially convert a Bluetooth chooser test to test > the interface and deletes the temporary tests that were created to test this > API. > > This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which > reverted the original change. The original change caused the > new-scan-device-added.html test to fail because of a Mojo validation error > resulting from not updating the > third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js > file needed by the test. > > Bug: 719827, 719826, 824704 , 826787 > Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 > Reviewed-on: https://chromium-review.googlesource.com/985195 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546729} TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org Change-Id: Ie2ef2af1ae74e8dd5ca01441027adaa59e6e0c0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 719827, 719826, 824704 , 826787 Reviewed-on: https://chromium-review.googlesource.com/986592 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#546851} [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/browser/layout_test/fake_bluetooth_chooser.cc [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/browser/layout_test/fake_bluetooth_chooser.h [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/content/shell/common/layout_test/fake_bluetooth_chooser.mojom [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/bluetooth_device.h [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/test/fake_central.cc [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/device/bluetooth/test/fake_peripheral.cc [add] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html [add] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/bluetooth/resources/bluetooth-helpers.js [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js [modify] https://crrev.com/d04a1e5256a9fdd78f40cbdb73355408614e14f3/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js
Comment 1 by ortuno@chromium.org
, Jul 11 2017Owner: ----
Status: Available (was: Assigned)