New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719825 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 569709



Sign in to add a comment

bluetooth: Implement FakeRemoteGATTDescriptor GATT operation responses

Project Member Reported by ortuno@chromium.org, May 9 2017

Issue description

Function to allow tests to simulate GATT operations (read, write).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0860f860f2292544f3e6fe0e97178ac5ab119596

commit 0860f860f2292544f3e6fe0e97178ac5ab119596
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Jun 26 02:36:17 2017

bluetooth: Implement setNextReadResponse (descriptor) and convert one test

Function to set the next read response for when a descriptor is read.

Bug: 719825
Change-Id: I50447f556b847c5dda9b097141bf8116e3a0ea44
Reviewed-on: https://chromium-review.googlesource.com/544375
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482185}
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/BUILD.gn
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/test/fake_central.h
[add] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/test/fake_read_response.cc
[add] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/test/fake_read_response.h
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/test/fake_remote_gatt_characteristic.cc
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/test/fake_remote_gatt_characteristic.h
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/test/fake_remote_gatt_descriptor.cc
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/device/bluetooth/test/fake_remote_gatt_descriptor.h
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-succeeds.html
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/0860f860f2292544f3e6fe0e97178ac5ab119596/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

Comment 2 by ortuno@chromium.org, Jul 11 2017

Cc: cco3@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/474e9bf390e7e4262a32c13665cecc05d641ff2f

commit 474e9bf390e7e4262a32c13665cecc05d641ff2f
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Fri Mar 23 17:45:26 2018

bluetooth: Impl. setNextWriteResponse (descriptor)

Also implements getLastWrittenValue() and converts two tests to use
these.

FakeRemoteGattDescriptor::setNextWriteResponse allows tests to set the
next response for a write.

BUG=719825

Change-Id: I2807d23a55f79eeca35338e25916c6d5e0115e89
Reviewed-on: https://chromium-review.googlesource.com/964901
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545508}
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/device/bluetooth/public/mojom/test/fake_bluetooth.mojom
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/device/bluetooth/test/fake_remote_gatt_descriptor.cc
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/device/bluetooth/test/fake_remote_gatt_descriptor.h
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-succeeds.html
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-updates-value.html
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth.mojom.js
[modify] https://crrev.com/474e9bf390e7e4262a32c13665cecc05d641ff2f/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js

Sign in to add a comment