New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 569709



Sign in to add a comment

bluetooth: Implement FakeRemoteGATTCharacteristic GATT operation responses

Project Member Reported by ortuno@chromium.org, May 9 2017

Issue description

Function to allow tests to simulate GATT operations (read, write, notify).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fb3597541edce9e948d3bbbdbefd34631a55467

commit 1fb3597541edce9e948d3bbbdbefd34631a55467
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Wed Jun 21 10:32:34 2017

bluetooth: Implement setNextGATTReadResponse and convert tests

Sets the next GATT Discovery request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that
range returned by specific platforms e.g. Android returns 0x101 to signal
a GATT failure
https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html#GATT_FAILURE


Bug:  719824 
Change-Id: I8502080bd700f248341af77a37e162fa06dff365
Reviewed-on: https://chromium-review.googlesource.com/541156
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481165}
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/device/bluetooth/test/fake_remote_gatt_characteristic.cc
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/device/bluetooth/test/fake_remote_gatt_characteristic.h
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/add-multiple-event-listeners.html
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-succeeds.html
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-updates-value.html
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/1fb3597541edce9e948d3bbbdbefd34631a55467/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e70dd389f94b6bfaf90d6ccfdb48967df06d66c

commit 9e70dd389f94b6bfaf90d6ccfdb48967df06d66c
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Jun 26 04:22:53 2017

bluetooth: Implement setNextWriteResponse (characteristic)

Also implements getLastWrittenValue() and converts a test to use these.

FakeRemoteGattCharacteristic.setNextWriteResponse() allows
tests to set the next response for a write with response request.


Bug:  719824 
Change-Id: Ieba74e14b03569b24c8c29b9badee6d20f55bfc5
Reviewed-on: https://chromium-review.googlesource.com/542755
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482195}
[modify] https://crrev.com/9e70dd389f94b6bfaf90d6ccfdb48967df06d66c/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
[modify] https://crrev.com/9e70dd389f94b6bfaf90d6ccfdb48967df06d66c/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/9e70dd389f94b6bfaf90d6ccfdb48967df06d66c/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/9e70dd389f94b6bfaf90d6ccfdb48967df06d66c/device/bluetooth/test/fake_remote_gatt_characteristic.cc
[modify] https://crrev.com/9e70dd389f94b6bfaf90d6ccfdb48967df06d66c/device/bluetooth/test/fake_remote_gatt_characteristic.h
[modify] https://crrev.com/9e70dd389f94b6bfaf90d6ccfdb48967df06d66c/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html
[modify] https://crrev.com/9e70dd389f94b6bfaf90d6ccfdb48967df06d66c/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

Comment 3 by ortuno@chromium.org, Jul 11 2017

Cc: cco3@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: odejesush@chromium.org
Status: Fixed (was: Untriaged)
Discussed with odejesush@ during triage and we believe this has been implemented.

Sign in to add a comment