New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719818 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 569709



Sign in to add a comment

bluetooth: Implement FakeRemoteGATTCharacteristic.addFakeDescriptor

Project Member Reported by ortuno@chromium.org, May 9 2017

Issue description

Function to allow tests to simulate descriptors and their properties.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fad2ae946aaf053c28da9d84ab83c0feaefa54b9

commit fad2ae946aaf053c28da9d84ab83c0feaefa54b9
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Thu Jun 22 02:37:15 2017

bluetooth: Implement AddFakeDescriptor and convert tests

Adds a fake GATT Descriptor with |uuid| to be discovered when
discovering the peripheral's GATT Attributes. Returns a
FakeRemoteGATTDescriptor corresponding to this descriptor. |uuid| should
be a BluetoothDescriptorUUID
https://webbluetoothcg.github.io/web-bluetooth/#typedefdef-bluetoothdescriptoruuid

Bug:  719818 
Change-Id: I765968e247c7ef0ad50395733796e3ce12e7e22d
Reviewed-on: https://chromium-review.googlesource.com/542278
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481411}
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/device/bluetooth/BUILD.gn
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/device/bluetooth/test/fake_remote_gatt_characteristic.cc
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/device/bluetooth/test/fake_remote_gatt_characteristic.h
[add] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/device/bluetooth/test/fake_remote_gatt_descriptor.cc
[add] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/device/bluetooth/test/fake_remote_gatt_descriptor.h
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-get-same-object.html
[add] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-get-same-object.html
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-get-same-object.js
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/fad2ae946aaf053c28da9d84ab83c0feaefa54b9/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

Comment 2 by ortuno@chromium.org, Jul 11 2017

Cc: cco3@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: odejesush@chromium.org
Discussed with odejesush@ during triage and we believe this has been implemented.
Status: Fixed (was: Untriaged)

Sign in to add a comment