New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719817 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 569709



Sign in to add a comment

bluetooth: Implement FakeRemoteGATTService.addFakeCharacteristic.

Project Member Reported by ortuno@chromium.org, May 9 2017

Issue description

Function to allow tests to simulate characteristics and their properties.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ead0cc625bda5a206a1c347c881d68bfe82b325e

commit ead0cc625bda5a206a1c347c881d68bfe82b325e
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Jun 16 19:48:14 2017

bluetooth: Generate getCharacteristic(s) tests

So that they are easier to refactor in the future.

Bug:  719817 ,  654670 
Change-Id: Ia75bbe12716f4df2dbe14c183e500c1f53ac7244
Reviewed-on: https://chromium-review.googlesource.com/538532
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480129}
[copy] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/blocklisted-characteristic.js
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/characteristic-not-found.js
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/device-disconnects-before.js
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/device-disconnects-during.js
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/device-goes-out-of-range.js
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/disconnect-called-before.js
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/disconnect-called-during.js
[copy] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/invalid-characteristic-name.js
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/reconnect-during.js
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/service-is-removed.js
[delete] https://crrev.com/f9a5a0bad8b766df4faa51fdb1c74f01318d0128/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/blocklisted-characteristic.html
[delete] https://crrev.com/f9a5a0bad8b766df4faa51fdb1c74f01318d0128/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/characteristic-not-found.html
[copy] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.html
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-characteristic-not-found.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-device-disconnects-before.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-device-disconnects-during.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-device-goes-out-of-range.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-disconnect-called-before.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-disconnect-called-during.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-invalid-characteristic-name.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-reconnect-during.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-service-is-removed.html
[delete] https://crrev.com/f9a5a0bad8b766df4faa51fdb1c74f01318d0128/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-not-found-with-uuid.html
[delete] https://crrev.com/f9a5a0bad8b766df4faa51fdb1c74f01318d0128/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/device-disconnects-before-with-uuid.html
[delete] https://crrev.com/f9a5a0bad8b766df4faa51fdb1c74f01318d0128/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/device-goes-out-of-range-with-uuid.html
[delete] https://crrev.com/f9a5a0bad8b766df4faa51fdb1c74f01318d0128/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/device-goes-out-of-range.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.html
[add] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-characteristic-not-found-with-uuid.html
[copy] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-disconnects-before-with-uuid.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-disconnects-before.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-disconnects-during-with-uuid.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-disconnects-during.html
[copy] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-goes-out-of-range-with-uuid.html
[copy] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-goes-out-of-range.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-disconnect-called-before-with-uuid.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-disconnect-called-before.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-disconnect-called-during-with-uuid.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-disconnect-called-during.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-invalid-characteristic-name.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-reconnect-during-with-uuid.html
[rename] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-reconnect-during.html
[copy] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-service-is-removed-with-uuid.html
[copy] https://crrev.com/ead0cc625bda5a206a1c347c881d68bfe82b325e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-service-is-removed.html
[delete] https://crrev.com/f9a5a0bad8b766df4faa51fdb1c74f01318d0128/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/service-is-removed-with-uuid.html
[delete] https://crrev.com/f9a5a0bad8b766df4faa51fdb1c74f01318d0128/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/service-is-removed.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01e6fd1c27261409a8efde2972aa4f9360453268

commit 01e6fd1c27261409a8efde2972aa4f9360453268
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Wed Jun 21 08:36:04 2017

bluetooth: Implement AddFakeCharacteristic and convert tests

Adds a fake GATT Characteristic with |uuid| and |properties|
to this fake service. The characteristic will be found when
discovering the peripheral's GATT Attributes. Returns a
FakeRemoteGATTCharacteristic corresponding to the added
characteristic.

Bug:  719817 
Change-Id: Ie00b962704e622ab2edfda23522d9e5bffbc9a3c
Reviewed-on: https://chromium-review.googlesource.com/540457
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481146}
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/BUILD.gn
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/test/fake_peripheral.cc
[add] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/test/fake_remote_gatt_characteristic.cc
[add] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/test/fake_remote_gatt_characteristic.h
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/test/fake_remote_gatt_service.cc
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/device/bluetooth/test/fake_remote_gatt_service.h
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/characteristic/characteristicProperties.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/blocklisted-characteristic.js
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/characteristic-not-found.js
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/get-same-object.js
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/invalid-characteristic-name.js
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/blocklisted-services.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/correct-services.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/characteristic-found.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-characteristic-not-found.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-get-same-object.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-invalid-characteristic-name.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/blocklisted-characteristics.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-found-with-uuid.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-found.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-not-found.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-characteristic-not-found-with-uuid.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-get-same-object-with-uuid.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-get-same-object.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-invalid-characteristic-name.html
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/01e6fd1c27261409a8efde2972aa4f9360453268/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

Comment 3 by ortuno@chromium.org, Jul 11 2017

Cc: cco3@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: odejesush@chromium.org
Status: Fixed (was: Untriaged)
Discussed with odejesush@ during triage and we believe this has been implemented.

Sign in to add a comment