New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719814 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 569709



Sign in to add a comment

bluetooth: Implement FakePeripheral.simulateGATTConnection

Project Member Reported by ortuno@chromium.org, May 9 2017

Issue description

Function to allow tests to simulate GATT connection responses.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c

commit a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c
Author: ortuno <ortuno@chromium.org>
Date: Mon Jun 05 04:40:19 2017

bluetooth: Implement setNextGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

BUG= 719814 

Review-Url: https://codereview.chromium.org/2874873003
Cr-Commit-Position: refs/heads/master@{#476940}

[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/device/bluetooth/test/fake_peripheral.cc
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/device/bluetooth/test/fake_peripheral.h
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/invalid-service-name.js
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/no-permission-for-any-service.js
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-succeeds.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/device-same-object.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-invalid-service-name.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-no-permission-for-any-service.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-invalid-service-name.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-no-permission-for-any-service-with-uuid.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-no-permission-for-any-service.html
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0255f6a703d6781b372fc905e6344722dce0abb9

commit 0255f6a703d6781b372fc905e6344722dce0abb9
Author: blundell <blundell@chromium.org>
Date: Mon Jun 05 09:17:18 2017

Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15 id:340001 of https://codereview.chromium.org/2874873003/ )

Reason for revert:
Seems to cause device-same-object test to fail consistently on Android, e.g.:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F65576%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout

Original issue's description:
> bluetooth: Implement setNextGATTConnectionResponse()
>
> Sets the next GATT Connection request response for peripheral with
> |address| to |code|. |code| could be an HCI Error Code from
> BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
> returned by specific platforms e.g. Android returns 0x101 to signal a GATT
> failure
>
> BUG= 719814 
>
> Review-Url: https://codereview.chromium.org/2874873003
> Cr-Commit-Position: refs/heads/master@{#476940}
> Committed: https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c

TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 719814 

Review-Url: https://codereview.chromium.org/2921233002
Cr-Commit-Position: refs/heads/master@{#476961}

[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/device/bluetooth/test/fake_peripheral.cc
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/device/bluetooth/test/fake_peripheral.h
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/invalid-service-name.js
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/no-permission-for-any-service.js
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-succeeds.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/device-same-object.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-invalid-service-name.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-no-permission-for-any-service.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-invalid-service-name.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-no-permission-for-any-service-with-uuid.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-no-permission-for-any-service.html
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/0255f6a703d6781b372fc905e6344722dce0abb9/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8799e7dac285e016327c6471863fb61a1405acab

commit 8799e7dac285e016327c6471863fb61a1405acab
Author: ortuno <ortuno@chromium.org>
Date: Wed Jun 07 01:48:47 2017

Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet:  http://crbug.com/729898 .
Removes device-same-object from SmokeTests to avoid it failing on bots.

TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG= 719814 

Review-Url: https://codereview.chromium.org/2919343004
Cr-Commit-Position: refs/heads/master@{#477510}

[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/device/bluetooth/test/fake_central.h
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/device/bluetooth/test/fake_peripheral.cc
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/device/bluetooth/test/fake_peripheral.h
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/invalid-service-name.js
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/no-permission-for-any-service.js
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-succeeds.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/device-same-object.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-invalid-service-name.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-no-permission-for-any-service.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-invalid-service-name.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-no-permission-for-any-service-with-uuid.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-no-permission-for-any-service.html
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/8799e7dac285e016327c6471863fb61a1405acab/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

Sign in to add a comment