Issue metadata
Sign in to add a comment
|
"Submit to CQ" button doesn't set Commit-Queue label |
||||||||||||||||||||||||
Issue descriptionThis is about https://chromium-review.googlesource.com/c/499488/ (that I'm going to submit soon, so its state will be different). It looks like a recent regression. When I click "Submit to CQ" or "CQ Dry run" buttons, the page flickers, but nothing else happens. In more detail, I see "Submit to CQ" label changing state to disabled and caption to "CQ Running...". A second later the page reloads, and there's no "Commit-Queue" label set (and the button is back to "Submit to CQ" caption). Chrome DevTools tell me that a click on "Submit to CQ" button results in HTTP POST to /review endpoint with following body: {drafts: "KEEP", labels: {}, message: "", reviewers: []} (which seems like a noop?..) --- Same happens with "CQ Dry Run" button. --- As a workaround I click "Reply", then pick Commit-Queue "+2" in the dialog, and the "Send". It works. (It results in POST to /review with following body: {drafts: "PUBLISH_ALL_REVISIONS", labels: {Commit-Queue: 2}, message: "", reviewers: []} )
,
May 9 2017
Reproduced it on https://chromium-review.googlesource.com/c/500187 - clicking the "Sumit to CQ" button has no effect other than a page flicker. Attached a screenshot with the network events that got triggered when pressing the button. Roughly the events between the top and bottom max_builds search in the picture.
,
May 9 2017
Thanks for the heads up. There was a frontend+plugins release yesterday. Will figure out whether changes to frontend or to plugin were responsible as soon as I'm at my desk.
,
May 9 2017
See my comments in https://bugs.chromium.org/p/chromium/issues/detail?id=719927
,
May 9 2017
Thanks for the dupe, Ravi. I'm chatting with the PG folks. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by machenb...@chromium.org
, May 9 2017