GetExtendedFileAttribute error log spam from HomeDirs::GetTrackedDirectory |
|||||||||
Issue descriptionHomeDirs::GetTrackedDirectory uses GetExtendedFileAttribute to locate tracked directories, but it results in emitting a lot of ERROR logs because GetExtendedFileAttribute is also called for directories which don't have the attribute.
,
May 11 2017
,
May 12 2017
,
May 12 2017
,
May 13 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6a215e39577c288f3b5e8539a4d808bbbddc78c7 commit 6a215e39577c288f3b5e8539a4d808bbbddc78c7 Author: Ryo Hashimoto <hashimoto@google.com> Date: Mon May 15 02:31:44 2017 cryptohome: Check xattr's presence before trying to get Platform::GetExtendedFileAttribute() emits error logs when trying to get non-existent xattr. To avoid log spam, we should check the presence first. BUG= chromium:719805 TEST=cros_workon_make cryptohome --test Change-Id: I660dfca58168bbeb8a22552be0b90cc275b0ea81 Reviewed-on: https://chromium-review.googlesource.com/499869 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> (cherry picked from commit f92305522780e947046640194b101602e90530ce) Reviewed-on: https://chromium-review.googlesource.com/505969 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/6a215e39577c288f3b5e8539a4d808bbbddc78c7/cryptohome/homedirs_unittest.cc [modify] https://crrev.com/6a215e39577c288f3b5e8539a4d808bbbddc78c7/cryptohome/homedirs.cc
,
May 15 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, May 11 2017