New issue
Advanced search Search tips

Issue 719763 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

ReadableStream.js refers to non-existent streamErrors.errInvalidHWM

Project Member Reported by toanpham@google.com, May 8 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36

Steps to reproduce the problem:
1. Look in source: src/third_party/WebKit/Source/core/streams/ReadableStream.js
2. 
3. 

What is the expected behavior?
Use 'streamErrors.invalidHWM'.

What went wrong?
Seems like a typo.

Did this work before? N/A 

Chrome version: 58.0.3029.96  Channel: stable
OS Version: 
Flash Version: 

Looks like WritableStream.js has this error as well.
 
Components: Blink>Network>StreamsAPI
Labels: TE-NeedsTriageHelp

Comment 2 by ricea@chromium.org, May 9 2017

Labels: -TE-NeedsTriageHelp OS-Android OS-Chrome OS-Mac OS-Windows
Owner: ricea@chromium.org
Status: Assigned (was: Unconfirmed)
Confirmed.

It looks like it doesn't cause a test failure because the RangeError is still created. I will create a Blink-specific test that verifies the actual text of the error so that we can catch this in future.

Comment 3 by ricea@chromium.org, Jun 13 2017

Labels: -Type-Bug Type-Bug-Regression
This is actually a regression introduced in https://codereview.chromium.org/2498983002 M57.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f4a499745ae9a8601e20ef616e8e1e877934269

commit 7f4a499745ae9a8601e20ef616e8e1e877934269
Author: ricea <ricea@chromium.org>
Date: Tue Jun 13 03:15:21 2017

Streams: Fix exception message for NaN HWM

ReadableStream and WritableStream both used streamErrors.errInvalidHWM
instead of streamErrors.invalidHWM for the message when a strategy
highWaterMark was NaN. This resulted in a RangeError being thrown with
an empty message. Because the web platform tests don't look at the
message, they didn't catch the bug.

Fix the message. Also add a Chromium-specific regression test to
validate that it is correct.

BUG= 719763 

Review-Url: https://codereview.chromium.org/2933853003
Cr-Commit-Position: refs/heads/master@{#478880}

[add] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/LayoutTests/http/tests/streams/chromium/err-invalid-hwm.html
[modify] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/Source/core/streams/ReadableStream.js
[modify] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/Source/core/streams/WritableStream.js

Comment 5 by ricea@chromium.org, Jun 13 2017

Status: Fixed (was: Assigned)

Sign in to add a comment