New issue
Advanced search Search tips

Issue 719752 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Fix to include correct header files in jumplist.{h,cc}

Project Member Reported by chengx@chromium.org, May 8 2017

Issue description

There are lots of header files included in jumplist.{h,cc}. We should delete duplicate and unused ones, and add the necessary ones according to the iwyu (include-what-you-use) rule.

 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5383621e52891f08341999f4e89a4def85b0b1cd

commit 5383621e52891f08341999f4e89a4def85b0b1cd
Author: chengx <chengx@chromium.org>
Date: Wed May 10 18:54:58 2017

Fix to include correct header files in jumplist.{h, cc}

This CL fixes jumplist.{h, cc} to include some necessary header files
according to the iwyu (include-what-you-use) rule, and to remove some
others which are redundant.

BUG= 719752 

Review-Url: https://codereview.chromium.org/2861393002
Cr-Commit-Position: refs/heads/master@{#470659}

[modify] https://crrev.com/5383621e52891f08341999f4e89a4def85b0b1cd/chrome/browser/win/jumplist.cc
[modify] https://crrev.com/5383621e52891f08341999f4e89a4def85b0b1cd/chrome/browser/win/jumplist.h

Comment 3 by chengx@chromium.org, May 16 2017

Description: Show this description

Comment 4 by chengx@chromium.org, May 16 2017

Description: Show this description

Comment 5 by chengx@chromium.org, May 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment