New issue
Advanced search Search tips

Issue 719751 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix dependencies on OutOfProcessPatcher.

Project Member Reported by sorin@chromium.org, May 8 2017 
The component updater classes have dependencies on OutOfProcessPatcher. Before this change, a client that needed to use the ComponentUnpacker had to include component_patcher_operation.h.

With this change, the client of ComponentUnpacker only needs to include component_unpacker.h

A couple of call sites were fixed too.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cca1c125366c60bc328af9697458aedd6c67aa17

commit cca1c125366c60bc328af9697458aedd6c67aa17
Author: sorin <sorin@chromium.org>
Date: Thu May 11 17:43:22 2017

Fix dependencies on OutOfProcessPatcher.

This is a mechanical change.

The component updater classes have dependencies on OutOfProcessPatcher.
Before this change, a client that needed to use the ComponentUnpacker
had to include component_patcher_operation.h.

With this change, the clients of ComponentUnpacker only need to include
component_unpacker.h

BUG= 719751 

Review-Url: https://codereview.chromium.org/2873513002
Cr-Commit-Position: refs/heads/master@{#471002}

[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/chrome/browser/component_updater/component_patcher_operation_out_of_process.h
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/BUILD.gn
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/component.cc
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/component.h
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/component_patcher_operation.cc
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/component_patcher_operation.h
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/component_unpacker.cc
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/component_unpacker.h
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/component_unpacker_unittest.cc
[add] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/out_of_process_patcher.h
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/test_configurator.cc
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/components/update_client/update_engine.h
[modify] https://crrev.com/cca1c125366c60bc328af9697458aedd6c67aa17/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Comment 2 by sorin@chromium.org, May 16 2017

Status: Fixed (was: Started)
►

Sign in to add a comment