git cl creds-check is overzealous regarding forced location |
|||
Issue description
OS: Linux
What steps will reproduce the problem?
(1) git cl creds-check
What is the expected result?
###
git is already configured to use your .gitcookies from /usr/local/google/home/nyquist/.gitcookies
Your .netrc and .gitcookies have credentials for these hosts:
Host User Which file
======================================= ======================== ===========
<snip>
chromium-review.googlesource.com git-nyquist.chromium.org .gitcookies
chromium.googlesource.com git-nyquist.chromium.org .gitcookies
No problems detected in your .gitcookies
###
What happens instead?
###
WARNING: you have configured custom path to .gitcookies: ~/.gitcookies
Gerrit and other depot_tools expect .gitcookies at /usr/local/google/home/nyquist/.gitcookies
However, your configured .gitcookies file is missing.
Reconfigure git to use default .gitcookies? Press Enter to reconfigure, or Ctrl+C to abort
Your .netrc and .gitcookies have credentials for these hosts:
Host User Which file
======================================= ======================== ===========
<snip>
chromium-review.googlesource.com git-nyquist.chromium.org .gitcookies
chromium.googlesource.com git-nyquist.chromium.org .gitcookies
No problems detected in your .gitcookies
###
Notes:
My ~ is /usr/local/google/home/nyquist so the overzealous regarding where the .gitcookies file should exist.
I would really want it to at least support ~ (and maybe even symbolic links going forward, but that's not important for this bug).
,
May 10 2017
Well, it certainly seems so. Fix: https://chromium-review.googlesource.com/501828
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/1e250cdeb344f096cbff4d515e333077b3b108a8 commit 1e250cdeb344f096cbff4d515e333077b3b108a8 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 10 13:52:16 2017 git cl creds-check: understand '~' in path to .gitcookies. Before, git cl creds-check expected `http.cookiefile` of git config to have path without '~' which git understands on Linux/Mac. R=machenbach@chromium.org Bug: 719728 Change-Id: Ica1308b776b62bda7a8b85113c0c0df837c7d933 Reviewed-on: https://chromium-review.googlesource.com/501828 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/1e250cdeb344f096cbff4d515e333077b3b108a8/git_cl.py
,
May 10 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tandrii@chromium.org
, May 10 2017