caroline swap size and lowmem margin mistakenly regressed |
|||||||||||
Issue descriptionI forgot to move the caroline config files to their new location after the recent changes to swap.sh. This fixes the issue. As a result of this bug, the caroline ToT and canaries are still running on the old swap size (6GB instead of the new value of 4GB) and the old discard margin (200MB instead of 400MB). However, min_filelist_kbytes is currently the intended larger value of 400MB (vs. 100MB previously).
,
May 8 2017
Very sorry: we need to merge this to 58 and 59 asap.
,
May 9 2017
+Bernie, let's try to get this in the next build (after today's)
,
May 9 2017
Yea it is too late for today but we can get tomorrow. Merge approved for 58.
,
May 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-caroline-private/+/9bfc545062e366e9cf1a3de5929d315ac38de3e1 commit 9bfc545062e366e9cf1a3de5929d315ac38de3e1 Author: Luigi Semenzato <semenzato@chromium.org> Date: Tue May 09 01:25:29 2017
,
May 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-caroline-private/+/766779c2263f36e8f7d72ac395f8a2747bd1cbf1 commit 766779c2263f36e8f7d72ac395f8a2747bd1cbf1 Author: Luigi Semenzato <semenzato@chromium.org> Date: Tue May 09 01:29:38 2017
,
May 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-caroline-private/+/cceaab8ace3329e23d6ac7d860246f67fde70f4d commit cceaab8ace3329e23d6ac7d860246f67fde70f4d Author: Luigi Semenzato <semenzato@chromium.org> Date: Tue May 09 18:29:15 2017
,
May 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-caroline-private/+/0d9ad19afbd038f7c57cc6eeb902ffe5d9ecbc4d commit 0d9ad19afbd038f7c57cc6eeb902ffe5d9ecbc4d Author: Luigi Semenzato <semenzato@google.com> Date: Tue May 09 21:19:12 2017
,
May 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-caroline-private/+/4e64595614eadf3bd6bda8fed924b680576e42cc commit 4e64595614eadf3bd6bda8fed924b680576e42cc Author: Luigi Semenzato <semenzato@google.com> Date: Tue May 09 21:45:22 2017
,
May 9 2017
It turns out that everything was working fine on the branches, because I only changed the location of those mm config files on ToT. So I reverted the changes on the branches, and left the one on ToT (which was really broken) and everything is fine. Sorry about this mess. Also, this didn't affect any release build. It would have affected 9334.66.0, but I lucked out and that build failed due to infra problems. The following build has not started yet, and is likely to start at 9pm.
,
May 9 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 19 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by semenzato@chromium.org
, May 8 2017