New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719718 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug

Blocked on:
issue 716174



Sign in to add a comment

Sliver of video underneath Media Remoting interstitial is showing

Project Member Reported by m...@chromium.org, May 8 2017

Issue description

See attached screenshot (with red mark-up). I suspect this may be due to the fact that I was running this on display hardware with a 1.5X device scale factor.

My theory is that, for compositing performance reasons, the video layer is being aligned to logical pixel boundaries. However, the DOM elements covering it are not. This leaves a "sliver" of 0.5 logical pixels on the left side of the video uncovered. As for possible solutions, maybe the bounds of the shadow DOM elements for the interstitial can be extended? Via CSS? And, would bleed-over be an issue, or are the shadow DOM elements clipped to their parent video element?



 
half_pixel_of_bleed_thru.png
60.6 KB View Download

Comment 1 by x...@chromium.org, May 9 2017

Cc: x...@chromium.org
Components: Blink>Paint
Owner: ka...@opera.com
This issue might relate to crbug.com/716174, where the boundary alignment seems different for video layer and the interstitial element (in media shadow dom) for some device scale factor.

karlo@: Feel free to assign it back if you think this is different. Thanks!
Cc: trchen@chromium.org
Components: Internals>GPU>Video
Labels: BugSource-Chromium PaintTeamTriaged-20170510
This might also be due to sub-pixel layer positioning which IIRC was recently landed.

It would only be related to crbug.com/716174 if there is a border around the video element, which doesn't seem to be the case. And that would happen in M-58 also. Could you verify those conditions and update the bug?

Note the link in the test case https://vimeo.com/193358188

I can't repro on Mac.

Comment 3 by x...@chromium.org, May 10 2017

The media remoting interstitial was introduced from M59.
So far this issue was only reported on display with 1.5X device scale factor.

Repro steps:
1. Enable #media-remoting flag in chrome://flags.
2. Mirroring a tab to a ChromeCast receiver (build 1.23).
3. Start playing any video (e.g. a local video, or any vimeo video) in tab.
4. Fullscreen the video, and wait for media remoting starts with the interstitial shown locally.

Please note the issue doesn't happens for all sizes. So the browser window might need to be resized to repro.

Comment 4 by m...@chromium.org, May 10 2017

re #3: That won't work in a Chromium build (need a Chrome-branded build).

We should wait for the other bug to be fixed, and then just re-check (on our end) whether this bug has been fixed.

Comment 5 by x...@chromium.org, May 11 2017

Blockedon: 716174

Comment 6 by sko...@chromium.org, Jun 12 2017

Labels: -M-60 M-61

Comment 7 by sko...@chromium.org, Aug 14 2017

Labels: -M-61 M-63

Comment 8 by m...@chromium.org, Aug 18 2017

This may have been fixed. Next time I have a local build going (since this repro'ed on my Linux Desktop very easily), I'll double-check.
Labels: -M-63 M-64
Owner: dbbrooks@chromium.org
dbbrooks@ can you please see whether you can repro in latest build?
Cc: ka...@opera.com

Comment 12 by m...@chromium.org, Dec 5 2017

Note that this only repro'ed on a desktop using a 1.5X device scaling factor. So, this will not repro on a Mac Retina (2X), or a traditional screen. (See original bug description for more details.)

Comment 13 by jrw@google.com, Dec 11 2017

Blockedon: 698796

Comment 14 by jrw@google.com, Dec 11 2017

Labels: -M-64 M-65

Comment 15 by amp@chromium.org, Dec 11 2017

Blockedon: -698796

Comment 16 by m...@chromium.org, Feb 1 2018

dbbrooks: Ping.

BTW--You should be able to set up the repro conditions by launching chrome with the --force-device-scale-factor=1.5 flag. And, be sure to try a few different window sizes to make sure the width of the window is an odd number of pixels. :)

Status: WontFix (was: Assigned)
On Chrome 65.0.3325.31, I just:

1. launched Chrome with the --force-device-scale-factor=1.5 flag 
2. Triggered Media Remoting
3. Verified that I didn't see the bug.
4. Stopped Media Remoting, resized the browser window, re-triggered Media Remoting and did not see the bug.
5. Repeated step 4 a few times with different window sizes.

So as long as these steps are sufficient, I'll close this bug as Won't Fix, no repro.

Sign in to add a comment