AVDA needs the routing token to create an overlay. ultimately, we want it to have access to this at all times. Initially, however, WMPI should send / revoke it identically to how it does with CVV.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ff93adf7ed746c0e945c250e52b8d30adfbf719 commit 2ff93adf7ed746c0e945c250e52b8d30adfbf719 Author: liberato <liberato@chromium.org> Date: Wed May 17 07:28:24 2017 Send AndroidOverlay routing token from WMPI to AVDA. This CL makes WMPI mirror the CVV surface ID logic with routing tokens for AndroidOverlay. The routing token is sent to AVDA, which does nothing with it. This CL also splits the existing RequestSurfaceCB into two separate callbacks. RequestSurfaceCB remains unchanged, providing a CVV id. This CL adds Request/Provide OverlayInfoCB to send the CVV id and/or the routing token. Most existing instances of R/P SurfaceCB are now R/P OverlayInfoCB instead, since everything from AVDA up to WMPI really wants whatever info it needs to create overlays. BUG= 719693 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2849043002 Cr-Commit-Position: refs/heads/master@{#472369} [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/chromecast/media/service/cast_mojo_media_client.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/content/renderer/media/android/media_player_renderer_client_factory.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/content/renderer/media/android/media_player_renderer_client_factory.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/content/renderer/render_frame_impl.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/content/renderer/render_frame_impl.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/base/BUILD.gn [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/base/media_switches.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/base/media_switches.h [add] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/base/overlay_info.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/base/renderer_factory.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/base/renderer_factory_selector_unittest.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/base/routing_token_callback.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/blink/webmediaplayer_impl_unittest.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/blink/webmediaplayer_params.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/blink/webmediaplayer_params.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/filters/gpu_video_decoder.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/filters/gpu_video_decoder.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/gpu/android_video_decode_accelerator.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/gpu/android_video_decode_accelerator.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/gpu/ipc/client/gpu_video_decode_accelerator_host.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/gpu/ipc/common/media_messages.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/gpu/ipc/service/gpu_video_decode_accelerator.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/gpu/ipc/service/gpu_video_decode_accelerator.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/mojo/clients/mojo_renderer_factory.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/mojo/clients/mojo_renderer_factory.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/mojo/services/interface_factory_impl.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/remoting/courier_renderer_factory.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/remoting/courier_renderer_factory.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/renderers/default_renderer_factory.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/renderers/default_renderer_factory.h [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/video/video_decode_accelerator.cc [modify] https://crrev.com/2ff93adf7ed746c0e945c250e52b8d30adfbf719/media/video/video_decode_accelerator.h
Comment 1 by yini...@chromium.org
, May 10 2017