Issue metadata
Sign in to add a comment
|
DCHECK when clicking on VPN row in system bubble |
||||||||||||||||||||||
Issue descriptionseems to be a result of crrev.com/b4f862467b0dce4e75b337f28fab0b7a5019f6ba stack trace: [20892:20892:0508/142033.407013:FATAL:network_icon.cc(465)] Check failed: shill::kTypeVPN != network_type (vpn vs. vpn) #0 0x55a15d690e0c base::debug::StackTrace::StackTrace() #1 0x55a15d6a9501 logging::LogMessage::~LogMessage() #2 0x55a15f7249f9 ash::network_icon::(anonymous namespace)::GetBasicImage() #3 0x55a15f723462 ash::network_icon::GetImageForNetwork() #4 0x55a15f7e8d26 ash::(anonymous namespace)::VPNListNetworkEntry::UpdateFromNetworkState() #5 0x55a15f7e8610 ash::VPNListView::AddNetwork() #6 0x55a15f7e8ab0 ash::VPNListView::AddProviderAndNetworks() #7 0x55a15f7e834f ash::VPNListView::AddProvidersAndNetworks() #8 0x55a15f7e7ee7 ash::VPNListView::Update() #9 0x55a15f7e5e45 ash::tray::NetworkStateListDetailedView::Init() #10 0x55a15f7b5f9c ash::TrayVPN::CreateDetailedView() #11 0x55a15f73778d ash::SystemTrayBubble::CreateItemViews() #12 0x55a15f737479 ash::SystemTrayBubble::UpdateView() #13 0x55a15f735af9 ash::SystemTray::ShowItems() #14 0x55a15f735e5c ash::SystemTray::ShowDetailedView()
,
May 9 2017
This appears to be the change that's causing the failure: https://cs.chromium.org/chromium/src/ash/system/network/network_icon.cc?rcl=52eb504ead78db774e2e21307e6322c1f7ce867f&l=620. Is there some reason that images were being created and never used for networks with type VPN in the NetworkIconImpl constructor? This seems to contradict https://chromium.googlesource.com/chromium/src/+/dce171b5f7d95. If this was just an oversight, then I can add a check to ensure that GetBasicImage is only called for non-VPN networks.
,
May 9 2017
,
May 9 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lesliewatkins@chromium.org
, May 8 2017