New issue
Advanced search Search tips

Issue 719658 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Bug



Sign in to add a comment

Don't build ZoomController or GuestViewBase for mobile platforms.

Project Member Reported by mcnee@chromium.org, May 8 2017

Issue description

ZoomController and GuestViewBase are being build for mobile platforms despite not being used.

We should update the build files to only build ZoomController when we have !is_android && !is_ios, and to only build GuestViewBase when we have enable_extensions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/336ea2c3ef2261939ee3be7b92da32896343249c

commit 336ea2c3ef2261939ee3be7b92da32896343249c
Author: mcnee <mcnee@chromium.org>
Date: Tue May 23 22:51:19 2017

Don't compile code for desktop zoom or GuestViews on mobile platforms.

Since desktop zoom is not used on mobile, we can remove the host zoom
settings, zoom level management, and related code from mobile builds.

GuestViews are also not needed on mobile, so we remove them as well.

BUG= 719658 

Review-Url: https://codereview.chromium.org/2874833002
Cr-Commit-Position: refs/heads/master@{#474093}

[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/android_webview/browser/aw_browser_context.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/profiles/off_the_record_profile_impl.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/profiles/profile.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/task_manager/web_contents_tags.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/ui/browser.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/ui/prefs/prefs_tab_helper.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/browser/ui/tab_contents/core_tab_helper.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/common/pref_names.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/common/pref_names.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/renderer/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/test/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chrome/test/base/testing_profile.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chromecast/browser/cast_browser_context.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/chromecast/browser/cast_browser_context.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/components/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/components/guest_view/browser/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/components/guest_view/renderer/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/components/zoom/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/browser/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/browser/storage_partition_impl.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/public/browser/BUILD.gn
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/public/browser/browser_context.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/public/browser/storage_partition.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/public/test/test_browser_context.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/public/test/test_browser_context.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/shell/browser/shell_browser_context.cc
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/shell/browser/shell_browser_context.h
[modify] https://crrev.com/336ea2c3ef2261939ee3be7b92da32896343249c/content/test/BUILD.gn

Comment 2 by mcnee@chromium.org, May 24 2017

Status: Fixed (was: Started)

Sign in to add a comment