OS: Chrome This bug is to track the work needed for ChromeVox to announce inline styles. We need to support rich text output for braille.
Previously landed changes: https://codereview.chromium.org/2903973002/ https://codereview.chromium.org/2540553002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f89d3572342f8a1bad997cec5fbabcdfe33aa5ef commit f89d3572342f8a1bad997cec5fbabcdfe33aa5ef Author: dtseng <dtseng@chromium.org> Date: Wed Jun 21 19:56:46 2017 add support for rich text selections BUG= 719654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2945703002 Cr-Commit-Position: refs/heads/master@{#481283} [modify] https://crrev.com/f89d3572342f8a1bad997cec5fbabcdfe33aa5ef/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/f89d3572342f8a1bad997cec5fbabcdfe33aa5ef/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f6bad48f3576c037c6863cda89e6a178fe30e5e commit 1f6bad48f3576c037c6863cda89e6a178fe30e5e Author: dtseng <dtseng@chromium.org> Date: Fri Jun 23 20:50:54 2017 Fix end of line announcements - fix Cursor.deepEquivalent to account for end of line selection offset. - add Cursor.deepEquivalent test coverage. - add spoken feedback for end of line. - add test coverage for end of line output. BUG= 719654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2948173004 Cr-Commit-Position: refs/heads/master@{#482021} [modify] https://crrev.com/1f6bad48f3576c037c6863cda89e6a178fe30e5e/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js [modify] https://crrev.com/1f6bad48f3576c037c6863cda89e6a178fe30e5e/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs [modify] https://crrev.com/1f6bad48f3576c037c6863cda89e6a178fe30e5e/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/1f6bad48f3576c037c6863cda89e6a178fe30e5e/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d919876ae05ce9d17ee8989543ae96d4b03176ac commit d919876ae05ce9d17ee8989543ae96d4b03176ac Author: dtseng <dtseng@chromium.org> Date: Fri Jun 23 22:26:58 2017 Turn on rich editable text by default TEST=chromevox_tests Editing*.* Manual: by character, word, line in complex html content editables - navigation - selection, deselection - deletion verify - braille output: cursor/selection, line bounds (up to but not beyond the current line) - speech output: text markers, styles, selection/deselection, deletion announcements - corner cases: end of line, selection spanning multiple lines. - complex html: basic output for selections over non-textual content utilizing Output BUG= 719654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2956663002 Cr-Commit-Position: refs/heads/master@{#482050} [modify] https://crrev.com/d919876ae05ce9d17ee8989543ae96d4b03176ac/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/d919876ae05ce9d17ee8989543ae96d4b03176ac/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47a02996a6e9acfd97e862df6732eeb78095d469 commit 47a02996a6e9acfd97e862df6732eeb78095d469 Author: dtseng <dtseng@chromium.org> Date: Fri Jun 23 23:45:03 2017 Provide link start and end speech output BUG= 719654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2955623002 Cr-Commit-Position: refs/heads/master@{#482073} [modify] https://crrev.com/47a02996a6e9acfd97e862df6732eeb78095d469/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/47a02996a6e9acfd97e862df6732eeb78095d469/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs [modify] https://crrev.com/47a02996a6e9acfd97e862df6732eeb78095d469/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f1b767b58201b9e51e71f32eb57c57e17bd4793 commit 2f1b767b58201b9e51e71f32eb57c57e17bd4793 Author: dtseng <dtseng@chromium.org> Date: Fri Jun 23 23:48:21 2017 Provide feedback for multi-line selections BUG= 719654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2957653002 Cr-Commit-Position: refs/heads/master@{#482075} [modify] https://crrev.com/2f1b767b58201b9e51e71f32eb57c57e17bd4793/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/2f1b767b58201b9e51e71f32eb57c57e17bd4793/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa5ea5a7134eef78d614541e209285e78705cd71 commit aa5ea5a7134eef78d614541e209285e78705cd71 Author: dtseng <dtseng@chromium.org> Date: Wed Jun 28 18:12:34 2017 Support rich line output in both speech and braille - scope rich output to only when moving to new line - this excludes character, word, selection movement and change - indicate bold, italic, underline in braille based on the current braille table - indicate all rich annotations in speech - do not indicate all rich annotations in braille; the large amount of output clutters the display; need alternate form/impl. TEST=editing_test and manually for various tables. BUG= 719654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2954413003 Cr-Commit-Position: refs/heads/master@{#483063} [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/chrome/browser/resources/chromeos/chromevox/braille/liblouis.js [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/chrome/browser/resources/chromeos/chromevox/braille/spans.js [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/chrome/test/data/chromeos/liblouis_nacl/test.js [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/third_party/liblouis/nacl_wrapper/liblouis_instance.cc [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc [modify] https://crrev.com/aa5ea5a7134eef78d614541e209285e78705cd71/third_party/liblouis/nacl_wrapper/translation_params.h
This is ready. Followups should come in new bugs.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9e77d4e0c30f4f59042fc63cf06255805bfbade commit c9e77d4e0c30f4f59042fc63cf06255805bfbade Author: dtseng <dtseng@chromium.org> Date: Fri Jun 30 22:43:38 2017 Expand EditableLine to include non-inline text box leafs BUG= 719654 TEST=snippets involving listitems withvarious style types, images to check the workaround works. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2965683002 Cr-Commit-Position: refs/heads/master@{#483849} [modify] https://crrev.com/c9e77d4e0c30f4f59042fc63cf06255805bfbade/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/c9e77d4e0c30f4f59042fc63cf06255805bfbade/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs [modify] https://crrev.com/c9e77d4e0c30f4f59042fc63cf06255805bfbade/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
Reopening due to issue 738641 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0481c5fa5c7338d35f40f38ae0130529f7bb5c6 commit c0481c5fa5c7338d35f40f38ae0130529f7bb5c6 Author: foolip <foolip@chromium.org> Date: Mon Jul 03 10:12:19 2017 Revert of Expand EditableLine to include non-inline text box leafs (patchset #6 id:100001 of https://codereview.chromium.org/2965683002/ ) Reason for revert: EditingTest.RichTextImageByCharacter is flaky (timeout) BUG= 738641 Original issue's description: > Expand EditableLine to include non-inline text box leafs > > BUG= 719654 > TEST=snippets involving listitems withvarious style types, images to check the workaround works. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2965683002 > Cr-Commit-Position: refs/heads/master@{#483849} > Committed: https://chromium.googlesource.com/chromium/src/+/c9e77d4e0c30f4f59042fc63cf06255805bfbade TBR=dmazzoni@chromium.org,dtseng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 719654 Review-Url: https://codereview.chromium.org/2968943003 Cr-Commit-Position: refs/heads/master@{#483976} [modify] https://crrev.com/c0481c5fa5c7338d35f40f38ae0130529f7bb5c6/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/c0481c5fa5c7338d35f40f38ae0130529f7bb5c6/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs [modify] https://crrev.com/c0481c5fa5c7338d35f40f38ae0130529f7bb5c6/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b29061177e782976f0a271510c6939c67529be35 commit b29061177e782976f0a271510c6939c67529be35 Author: dtseng <dtseng@chromium.org> Date: Mon Jul 03 18:28:20 2017 Reland: Expand EditableLine to include non-inline text box leafs Original issue: https://codereview.chromium.org/2965683002/ BUG= 719654 TBR=dtseng@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2966973002 Cr-Commit-Position: refs/heads/master@{#484026} [modify] https://crrev.com/b29061177e782976f0a271510c6939c67529be35/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/b29061177e782976f0a271510c6939c67529be35/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs [modify] https://crrev.com/b29061177e782976f0a271510c6939c67529be35/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2d2b47134d156b17403ae34ece29e7dcc0cba6b commit d2d2b47134d156b17403ae34ece29e7dcc0cba6b Author: David Tseng <dtseng@chromium.org> Date: Wed Aug 02 05:09:54 2017 Introduce in-lined rich text annotations in braille - we insert annotations only to describe the context of the current selection's ancestry - we don't annotate things outside of the selection to avoid cluttering small displays - output module extended to support braille specific only rules - added brl specific msgs for table and cell Test: updates made to existing editing tests. Manually test against tables. Bug: 719654 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iac8a62d666d217a7046ea33b78517d1f29dce027 Reviewed-on: https://chromium-review.googlesource.com/592166 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#491274} [modify] https://crrev.com/d2d2b47134d156b17403ae34ece29e7dcc0cba6b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js [modify] https://crrev.com/d2d2b47134d156b17403ae34ece29e7dcc0cba6b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/d2d2b47134d156b17403ae34ece29e7dcc0cba6b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs [modify] https://crrev.com/d2d2b47134d156b17403ae34ece29e7dcc0cba6b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js [modify] https://crrev.com/d2d2b47134d156b17403ae34ece29e7dcc0cba6b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs [modify] https://crrev.com/d2d2b47134d156b17403ae34ece29e7dcc0cba6b/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
Comment 1 by dtseng@chromium.org
, Jun 12 2017