Android service "stuck" in memory
Reported by
rodymac...@gmail.com,
May 8 2017
|
|||||||
Issue descriptionSteps to reproduce the problem: 1. Download media with Chrome (i.e: an image) 2. Go to settings > developer options > running services 3. Locate Chrome in the list, and see that the "DownloadNotificationService" keeps running after the download is finished. What is the expected behavior? The service must be cleared upon download completion What went wrong? The service is started and keeps running indefinitely. This never happened before Chrome updated to v58 Did this work before? Yes v57 and before Chrome version: 58.0.3029.83 Channel: stable OS Version: 6.0.1 Flash Version:
,
May 8 2017
,
May 11 2017
,
Jun 2 2017
,
Jun 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea0d919e615ab0c864ba5331c91e640dde5a946f commit ea0d919e615ab0c864ba5331c91e640dde5a946f Author: David Trainor <dtrainor@chromium.org> Date: Sat Jun 03 02:22:55 2017 On Pre-O kill the download service Allow the downloads service to die if there are no active downloads running anymore. This includes any in-progress or paused downloads. This also only relates to pre-O, where the service will not run as a foreground service. BUG= 719641 Change-Id: I37ef325eff5675530fcca2e3f63efc98094a5cab Reviewed-on: https://chromium-review.googlesource.com/517749 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#476862} [modify] https://crrev.com/ea0d919e615ab0c864ba5331c91e640dde5a946f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/ea0d919e615ab0c864ba5331c91e640dde5a946f/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
,
Jun 3 2017
So... it'll be fixed in the next Chrome update?
,
Jun 5 2017
,
Jun 5 2017
Depending on whether or not it gets merged, it'll be in M-60 or M-61. Will update bug when we figure out if we want to merge it.
,
Jun 5 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
Good to know it's been fixed. Being merged to M60 means it'll be applied in the next Chrome update (v59)?
,
Jun 7 2017
Sadly it won't make it until M60.
,
Jun 9 2017
I don't know if this fix was supposed to show up in v60 beta, but I just tried it, and the problem persists. The service isn't shut down even after manually sliding the app away from the recent apps list.
,
Jun 9 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2017
Was merged right now. Needed to be left on trunk for a bit. Will be there during the next beta push.
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03cc4bb2027b94bc928452d83d679c3c8c5fcfbb commit 03cc4bb2027b94bc928452d83d679c3c8c5fcfbb Author: David Trainor <dtrainor@chromium.org> Date: Fri Jun 09 22:04:37 2017 On Pre-O kill the download service Allow the downloads service to die if there are no active downloads running anymore. This includes any in-progress or paused downloads. This also only relates to pre-O, where the service will not run as a foreground service. BUG= 719641 TBR=dtrainor@chromium.org (cherry picked from commit ea0d919e615ab0c864ba5331c91e640dde5a946f) Change-Id: I37ef325eff5675530fcca2e3f63efc98094a5cab Reviewed-on: https://chromium-review.googlesource.com/517749 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#476862} Reviewed-on: https://chromium-review.googlesource.com/530010 Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#300} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/03cc4bb2027b94bc928452d83d679c3c8c5fcfbb/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/03cc4bb2027b94bc928452d83d679c3c8c5fcfbb/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by raila...@gmail.com
, May 8 2017