New issue
Advanced search Search tips

Issue 719590 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Exposed] attribute on partial interfaces is not used

Project Member Reported by peter@chromium.org, May 8 2017

Issue description

The [Exposed] attribute is valid to use on partial interfaces per WebIDL:

https://heycam.github.io/webidl/#Exposed

We don't currently seem to consider it in the generated code. IDLCompiler.md says the following:

  >> Some extended attributes are transferred from the dependency interface
  >> definition to its members, because otherwise there is no way to apply the
  >> attributes to "just the members in this definition", due to merging. These
  >> are extended attributes for turning off a dependency interface, namely:
  >> `[Conditional], [PerContextEnabled],` and `[RuntimeEnabled].`

There are a few instances where a partial interfaces defined more restrictive exposure than the parent interface. I'm updating these in a CL, as *not* exposing them would have a bug, so in this case we got lucky.

https://codereview.chromium.org/2866023003/

I'm not aware of any users that require this behaviour for now, but we should track that we don't implement it.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bc2a1a08b1aa381876ff335ad2f3139abe1e2a2

commit 3bc2a1a08b1aa381876ff335ad2f3139abe1e2a2
Author: peter <peter@chromium.org>
Date: Mon May 08 17:38:45 2017

Update Notification and Background Sync partial interface exposure

The ServiceWorkerRegistration base interface is exposed in all windows
and workers, so partial interfaces that extend it should define the
same.

In practice this already is the case, as our code generator does not
consider the [Exposed] attribute in this scenario.

BUG=719590

Review-Url: https://codereview.chromium.org/2866023003
Cr-Commit-Position: refs/heads/master@{#470039}

[modify] https://crrev.com/3bc2a1a08b1aa381876ff335ad2f3139abe1e2a2/third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.idl
[modify] https://crrev.com/3bc2a1a08b1aa381876ff335ad2f3139abe1e2a2/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl

Project Member

Comment 2 by sheriffbot@chromium.org, May 9 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment