New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Opening onscreen keyboard crashes in --mus

Project Member Reported by moshayedi@chromium.org, May 8 2017

Issue description

Enable Onscreen keyboard, and click on its icon in system tray. It crashes with a DCHECK failure & following stack trace:

[1487:1487:0508/110929.656133:FATAL:ozone_platform.cc(69)] Check failed: instance_. OzonePlatform is not initialized
#0 0x7fea429d436c base::debug::StackTrace::StackTrace()
#1 0x7fea429f8441 logging::LogMessage::~LogMessage()
#2 0x7fea3d5beef6 ui::OzonePlatform::GetInstance()
#3 0x7fea3d45a026 keyboard::KeyboardController::ShowKeyboardInternal()
#4 0x7fea3d45b9ec keyboard::KeyboardLayoutManager::SetChildBounds()
#5 0x7fea3d45b6dd keyboard::KeyboardLayoutManager::OnWindowResized()
#6 0x7fea3e9d9365 aura::Window::OnLayerBoundsChanged()
#7 0x7fea3e94f369 ui::Layer::SetBoundsFromAnimation()
#8 0x7fea3e9d67b5 aura::Window::SetBoundsInternal()
#9 0x7fea3d8c55f6 ash::WmWindow::SetBoundsDirect()
#10 0x7fea3d8ba164 ash::wm::WmSnapToPixelLayoutManager::SetChildBounds()
#11 0x7fea3d45b93c keyboard::KeyboardLayoutManager::SetChildBounds()
#12 0x7fea3dc45a85 (anonymous namespace)::KeyboardContentsDelegate::MoveContents()
#13 0x7fea4039103e content::RenderViewHostImpl::OnRequestMove()
#14 0x7fea40390f24 _ZN3IPC8MessageTI28ViewHostMsg_RequestMove_MetaSt5tupleIJN3gfx4RectEEEvE8DispatchIN7content18RenderViewHostImplES9_vMS9_FvRKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#15 0x7fea403901c2 content::RenderViewHostImpl::OnMessageReceived()
#16 0x7fea40394c84 content::RenderWidgetHostImpl::OnMessageReceived()
#17 0x7fea4038146f content::RenderProcessHostImpl::OnMessageReceived()
#18 0x7fea41c94741 IPC::ChannelProxy::Context::OnDispatchMessage()
#19 0x7fea41c974f3 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE
#20 0x7fea429bf849 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#21 0x7fea429d4d04 base::debug::TaskAnnotator::RunTask()
#22 0x7fea42a04b99 base::MessageLoop::RunTask()
#23 0x7fea42a04f5f base::MessageLoop::DeferOrRunPendingTask()
#24 0x7fea42a0534d base::MessageLoop::DoWork()
#25 0x7fea42a07a59 base::MessagePumpLibevent::Run()
#26 0x7fea42a04922 base::MessageLoop::RunHandler()
#27 0x7fea42a39509 base::RunLoop::Run()
#28 0x7fea440fc14b ChromeBrowserMainParts::MainMessageLoopRun()
#29 0x7fea4007c8e7 content::BrowserMainLoop::RunMainMessageLoopParts()
#30 0x7fea4007f5c6 content::BrowserMainRunnerImpl::Run()
#31 0x7fea40077f4f content::BrowserMain()
#32 0x7fea40863f4c content::ContentMainRunnerImpl::Run()
#33 0x7fea42f03ea9 service_manager::Main()
#34 0x7fea40862b74 content::ContentMain()
#35 0x7fea4375d851 ChromeMain
#36 0x7fea376fbf45 __libc_start_main
#37 0x7fea4375d6c3 <unknown>


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e69195aa6646b2f6e481e5f1e0fbc82cc807d58a

commit e69195aa6646b2f6e481e5f1e0fbc82cc807d58a
Author: moshayedi <moshayedi@chromium.org>
Date: Wed May 10 04:55:10 2017

Fix Onscreen Keyboard crash in --mus.

OzonePlatform is instantiated in mus-ws in --mus and we don't have access to it
in ui::KeyboardController. Trying to access OzonePlatform here failed the
DCHECK() in ui::OzonePlatform::GetInstance().

BUG= 719540 

Review-Url: https://codereview.chromium.org/2871673004
Cr-Commit-Position: refs/heads/master@{#470462}

[modify] https://crrev.com/e69195aa6646b2f6e481e5f1e0fbc82cc807d58a/ui/keyboard/keyboard_controller.cc

Status: Fixed (was: Started)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Components: -MUS>Phase>1

Sign in to add a comment