New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719539 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.7% regression in thread_times.key_idle_power_cases at 469616:469623

Project Member Reported by kraynov@chromium.org, May 8 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=719539

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgivmu6ggM


Bot(s) for this bug's original alert(s):

android-webview-nexus6

=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : thread_times.key_idle_power_cases
  Metric       : tasks_per_second_total_all/animated-gif.html


To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=animated.gif.html thread_times.key_idle_power_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980150540339602560

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6524608271876096


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: delph...@chromium.org
Owner: delph...@chromium.org

=== Auto-CCing suspected CL author delphick@chromium.org ===

Hi delphick@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : delphick
  Commit : 9db74aa87f97c709baf5d38b82fb987713a40951
  Date   : Fri May 05 10:20:49 2017
  Subject: Create new action sent when a BeginMainFrame not expected before vsync.

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : thread_times.key_idle_power_cases
  Metric       : tasks_per_second_total_all/animated-gif.html
  Change       : 4.43% | 753.420919145 -> 786.776349213

Revision             Result                  N
chromium@469615      753.421 +- 19.9927      6      good
chromium@469617      749.773 +- 9.00842      6      good
chromium@469618      758.441 +- 14.9069      6      good
chromium@469619      787.55 +- 19.8329       6      bad       <--
chromium@469623      786.776 +- 18.4939      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=animated.gif.html thread_times.key_idle_power_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980150532919442496

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5866458136969216


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : delphick
  Commit : 9db74aa87f97c709baf5d38b82fb987713a40951
  Date   : Fri May 05 10:20:49 2017
  Subject: Create new action sent when a BeginMainFrame not expected before vsync.

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : thread_times.key_idle_power_cases
  Metric       : tasks_per_second_total_all/animated-gif.html
  Change       : 3.86% | 753.073724894 -> 782.131445973

Revision             Result                  N
chromium@469615      753.074 +- 15.1378      6      good
chromium@469617      759.486 +- 17.5355      6      good
chromium@469618      748.317 +- 10.7488      6      good
chromium@469619      775.939 +- 10.9996      6      bad       <--
chromium@469623      782.131 +- 17.7396      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=animated.gif.html thread_times.key_idle_power_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980148795487479840

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6524608271876096


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Started (was: Untriaged)
This is mostly expected* as we're now sending a message from the cc scheduler to say that we're not expecting a MainFrame. Unfortunately any regular timer (like this test's animated GIF with 100ms frame transitions) that causes a MainFrame with a period of 16<x<100 ms is probably the worst case for this change as this message will be sent for about 50-100% of all frames.

I'm working on a new change that would make the renderer scheduler signal to the cc scheduler that it's interested in this message otherwise the message will be suppressed.

* This ignores the fact that this regression is for animations running in the background and therefore the test should probably have shown ~0 tasks per second both before and after my change.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, May 12 2017

Cc: jrumm...@chromium.org
 Issue 721908  has been merged into this issue.
Cc: shrike@chromium.org
 Issue 728447  has been merged into this issue.
Status: Fixed (was: Started)
This is reduced now

Sign in to add a comment