New issue
Advanced search Search tips

Issue 719532 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename kNodeTypeJavaScript to kNodeTypeScriptProcessor

Project Member Reported by rtoy@chromium.org, May 8 2017 
The old JavascriptNode was renamed to ScriptProcessorNode years ago.  Update the enum name to match.
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd5c0cc74fa7a0be9318a9cd69460d5fea4c66ad

commit cd5c0cc74fa7a0be9318a9cd69460d5fea4c66ad
Author: rtoy <rtoy@chromium.org>
Date: Tue May 09 04:09:36 2017

Rename kNodeTypeJavaScript to kNodeTypeScriptProcessor

The old Javascript node was renamed to ScriptProcessor long ago.  Make
the enum match the actual node name.

No changes in behavior.

BUG= 719532 
TEST=none

Review-Url: https://codereview.chromium.org/2872553004
Cr-Commit-Position: refs/heads/master@{#470184}

[modify] https://crrev.com/cd5c0cc74fa7a0be9318a9cd69460d5fea4c66ad/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/cd5c0cc74fa7a0be9318a9cd69460d5fea4c66ad/third_party/WebKit/Source/modules/webaudio/AudioNode.h
[modify] https://crrev.com/cd5c0cc74fa7a0be9318a9cd69460d5fea4c66ad/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp

Comment 2 by rtoy@chromium.org, May 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment