Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 4 users
Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Task


Participants' hotlists:
Payment-Interop


Sign in to add a comment
Deprecate issuer networks as method names for PaymentRequest
Project Member Reported by rouslan@chromium.org, May 8 Back to list
Web developers should use 'basic-card' instead.

 
Summary: Warn web developers that issuer networks as method names are deprecated. (was: Warn web developers that card types as method names are deprecated.)
Labels: -Type-Bug Type-Launch-OWP
Summary: Deprecate issuer networks as method names for PaymentRequest (was: Warn web developers that issuer networks as method names are deprecated.)
Project Member Comment 4 by bugdroid1@chromium.org, May 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07557aac9176d0b67f0a055db42d9c9ed23e0ed0

commit 07557aac9176d0b67f0a055db42d9c9ed23e0ed0
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Wed May 17 14:02:51 2017

Add a use counter for "visa", "amex", etc payment methods.

Bug: 719526
Change-Id: I6c25fd781b7aaa7df9209cc925a4c15146557bdb
Reviewed-on: https://chromium-review.googlesource.com/506748
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472446}
[modify] https://crrev.com/07557aac9176d0b67f0a055db42d9c9ed23e0ed0/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/07557aac9176d0b67f0a055db42d9c9ed23e0ed0/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/07557aac9176d0b67f0a055db42d9c9ed23e0ed0/tools/metrics/histograms/enums.xml

Project Member Comment 5 by bugdroid1@chromium.org, May 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5c20b710a753c0992126b1176015849400ca31

commit 9e5c20b710a753c0992126b1176015849400ca31
Author: rouslan <rouslan@chromium.org>
Date: Tue May 23 18:39:41 2017

Warn web developers that card networks as method names are deprecated.

Web developers should use 'basic-card' instead. Deprecated:

  new PaymentRequest(
    [{
      supportedMethods: ['visa', 'amex'],
    }],
    cart);

Should be used:

  new PaymentRequest(
    [{
      supportedMethods: ['basic-card'],
      data: {supportedNetworks: ['visa', 'amex']},
    }],
    cart);

Console warning message:
  [Deprecation] Card issuer network ("amex", "diners", "discover",
  "jcb", "mastercard", "mir", "unionpay", "visa") as payment method is
  deprecated and will be removed in M64, around January 2018. Please use
  payment method name "basic-card" with issuer network in the
  "supportedNetworks" field instead. See
  https://www.chromestatus.com/features/5725727580225536 for more
  details.

Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQAQAJ

BUG=719526

Review-Url: https://codereview.chromium.org/2865023003
Cr-Commit-Position: refs/heads/master@{#473997}

[modify] https://crrev.com/9e5c20b710a753c0992126b1176015849400ca31/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/9e5c20b710a753c0992126b1176015849400ca31/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
depreciated
bug
Sign in to add a comment