Issue metadata
Sign in to add a comment
|
unit_tests failing on chromium.memory/Linux TSan Tests |
||||||||||||||||||||||
Issue descriptionunit_tests failing on chromium.memory/Linux TSan Tests Builders failed on: - Linux TSan Tests: https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests NotificationPlatformBridgeLinuxTest.NotifyAndCloseFormat has been triggering the data race detection in TSAN periodically (8 of the last 50 builds), so I'm disabling the flaky test. The race condition is probably real, though, and should be checked out.
,
May 8 2017
Recent flakes: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/5418 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/5410 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/5405 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/5399 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/5396 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/5386 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/5382 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/5374 All appear to fail in the same way.
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddc4e027e9532bede5216ac3288eee5bd582ed08 commit ddc4e027e9532bede5216ac3288eee5bd582ed08 Author: iclelland <iclelland@chromium.org> Date: Mon May 08 15:07:39 2017 Disabling flaky unit test. The test is marked as triggering a data race by TSAN occasionally (8 builds of the most recent 50). Disabling as flaky. BUG= 719485 TBR=thomasanderson@chromium.org Review-Url: https://codereview.chromium.org/2864353003 Cr-Commit-Position: refs/heads/master@{#469985} [modify] https://crrev.com/ddc4e027e9532bede5216ac3288eee5bd582ed08/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
,
May 8 2017
Removing Sheriff-Chromium label; test is disabled and bug tentatively assigned.
,
May 8 2017
,
May 8 2017
Findit suggests https://codereview.chromium.org/2857293002/ as the CL to have introduced the flaky test according to analysis https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyswELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ9Y2hyb21pdW0ubWVtb3J5L0xpbnV4IFRTYW4gVGVzdHMvNTMwMC91bml0X3Rlc3RzL1RtOTBhV1pwWTJGMGFXOXVVR3hoZEdadmNtMUNjbWxrWjJWTWFXNTFlRlJsYzNRdVRtOTBhV1o1UVc1a1EyeHZjMlZHYjNKdFlYUT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Can someone please help verify? Thanks, Jeff on behalf of Findit team
,
May 8 2017
Correct, but we knew that already :)
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cec16ad195ac43f821606e8e17e04e32d2539867 commit cec16ad195ac43f821606e8e17e04e32d2539867 Author: thomasanderson <thomasanderson@google.com> Date: Tue May 09 04:20:04 2017 Linux native notifications: fix Tsan failure in NotifyAndCloseFormat Gmock cannot have EXPECT_CALL's intersparsed with actual calls in a multithreaded environment. This CL changes NotificationPlatformBridgeLinuxTest to specify all EXPECT_CALL's before creating the task runner thread. BUG= 719485 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2867203002 Cr-Commit-Position: refs/heads/master@{#470197} [modify] https://crrev.com/cec16ad195ac43f821606e8e17e04e32d2539867/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
,
May 9 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by olka@chromium.org
, May 8 2017