New issue
Advanced search Search tips

Issue 719478 link

Starred by 1 user
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add edit buttons to item list rows

Project Member Reported by anthonyvd@chromium.org, May 8 2017 
The rows in all list sheets except the shipping option should end with a pencil icon that opens the appropriate editor when clicked.
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e0e8bda501273ef5b6669370bed2999efdf0f85

commit 1e0e8bda501273ef5b6669370bed2999efdf0f85
Author: anthonyvd <anthonyvd@chromium.org>
Date: Mon May 15 20:46:11 2017

[Web Payments] Add "pencil" edit button to lists.

BUG= 719478 

Review-Url: https://codereview.chromium.org/2872623002
Cr-Commit-Position: refs/heads/master@{#471890}

[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/chrome/browser/ui/views/payments/payment_request_item_list.h
[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/chrome/browser/ui/views/payments/payment_request_item_list_unittest.cc
[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
[modify] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/ui/vector_icons/BUILD.gn
[add] https://crrev.com/1e0e8bda501273ef5b6669370bed2999efdf0f85/ui/vector_icons/edit.icon

Comment 2 by anthonyvd@chromium.org, May 17 2017

Status: Fixed (was: Assigned)

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment