New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719477 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

53.5% regression in blink_perf.paint at 469248:469301

Project Member Reported by kraynov@chromium.org, May 8 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=719477

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgipmt4wkM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel

=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.paint
  Metric       : large-table-repaint/large-table-repaint

Revision             Result                  N
chromium@469247      186.164 +- 10.2654      21      good
chromium@469301      184.805 +- 10.8866      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980157345625719184

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5812523816714240


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.paint
  Metric       : large-table-repaint/large-table-repaint

Revision             Result                  N
chromium@469247      280.33 +- 22.7127       21      good
chromium@469301      283.187 +- 32.6298      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980157354027415488

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6377981846487040


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.paint
  Metric       : large-table-repaint/large-table-repaint

Revision             Result                  N
chromium@469247      280.499 +- 27.1958      21      good
chromium@469301      280.114 +- 33.4543      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980141252529239392

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5812523816714240


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: ben@chromium.org
Owner: ben@chromium.org

=== Auto-CCing suspected CL author ben@chromium.org ===

Hi ben@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : ben
  Commit : 457a0ccf74d873f62036e0733a9e6fc5e005e03d
  Date   : Thu May 04 05:49:29 2017
  Subject: Fix a TODO in GN file

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.paint
  Metric       : large-table-repaint/large-table-repaint
  Change       : 3.33% | 188.041321429 -> 184.68625

Revision             Result                  N
chromium@469247      188.041 +- 10.2658      14      good
chromium@469274      187.862 +- 13.0971      14      good
chromium@469277      188.531 +- 7.11062      9       good
chromium@469279      192.77 +- 6.52011       6       good
chromium@469280      185.019 +- 10.937       21      bad       <--
chromium@469286      184.201 +- 9.7286       14      bad
chromium@469301      184.686 +- 8.96712      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980141247749289344

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6377981846487040


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: jasonkliu@chromium.org
 Issue 719476  has been merged into this issue.
Cc: -jasonkliu@chromium.org
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
this test is bimodal; it goes up and down in the graphs, and the bisect picks culprits when it goes up :(

Sign in to add a comment