New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719451 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Running WebViewThreadTest fails

Reported by elkri...@gmail.com, May 8 2017

Issue description

Steps to reproduce the problem:
1.checkout code for Androidwebview testing 
2. Try and run the WebViewThreadTest
3. get exception 
4. Tests failed. 

What is the expected behavior?
test to pass.

What went wrong?
Exception stopped the tests: 

java.lang.IllegalStateException: Calling View methods on another thread than the UI thread.
at com.android.webview.chromium.WebViewChromium.createThreadException(WebViewChromium.java:297)
at com.android.webview.chromium.WebViewChromium.checkThread(WebViewChromium.java:312)
at com.android.webview.chromium.WebViewChromium.init(WebViewChromium.java:225)
at android.webkit.WebView.<init>(WebView.java:636)
at android.webkit.WebView.<init>(WebView.java:572)
at android.webkit.WebView.<init>(WebView.java:555)
at android.webkit.WebView.<init>(WebView.java:542)
at android.webkit.WebView.<init>(WebView.java:532)
at WebViewThreadTestActivity$2.run(WebViewThreadTestActivity.java:132)
at java.lang.Thread.run(Thread.java:761)

Test running failed: Instrumentation run failed due to 'Process crashed.' 

Did this work before? N/A 

Chrome version: android Nougat  Channel: stable
OS Version: API 25
Flash Version:
 
Components: Mobile>WebView
I see no issues here.

$ ninja -C out/Default system_webview_shell_layout_test_apk -j1500 -l30
$ out/Default/bin/run_system_webview_shell_layout_test_apk -f WebViewThreadTest#*
Labels: -Pri-2 Pri-3
Owner: timvolod...@chromium.org
Status: Assigned (was: Unconfirmed)
The team tells me that Tim maintains system_webview_shell_layout_test_apk.

Tim, what are the expectations for these tests? Do these depend on installed version of SystemWebView.apk, or do they have a built-in WebView (like webview_instrumentation_test_apk, formerly known as android_webview_test_apk).

I was actually able to run these even without a SystemWebViewShell.apk installed, but I don't know if these tests depend on other variables.
Cc: ntfschr@chromium.org
Cc: aluo@chromium.org yolandyan@chromium.org
The layout tests depend on the installed version of system webview, it does not require for the SystemWebViewShell to be installed though (there is some explanation in android_webview/tools/system_webview_shell/test/data/run_tests_rebaseline.sh)

IIRC the WebViewThreadTest in question was actually added by aluo@, adding: +aluo@, +yolandyan@

Comment 6 by aluo@chromium.org, May 15 2017

Owner: aluo@chromium.org
I'll take a look

Comment 7 by aluo@chromium.org, May 15 2017

Cc: ti...@chromium.org

Comment 8 by aluo@chromium.org, May 16 2017

Labels: Needs-Feedback
Tried on stable build and latest M60 build of webview on Nexus 5 MRA58N, all 10 tests are passing.  Could you please provide some more info:

1) Device + Android version
2) WebView apk version (Chrome version if it's Android N)
3) command used to run test
4) logcat from test run
5) which commit of chromium repo

Comment 9 by elkri...@gmail.com, May 23 2017

Hi,
I've deleted the repo and pulled a clean version. 
All is working. 

Comment 10 by torne@chromium.org, May 23 2017

Status: WontFix (was: Assigned)

Sign in to add a comment