New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 719446 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
isherman@chromium.org
altimin@chromium.org
asvitk...@chromium.org
skare@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Prevent overflows in long-running UMA

Project Member Reported by altimin@chromium.org, May 8 2017 
At the moment an accumulation of all samples stored in the UMA and a delta is computed from snapshots for uploading. This can lead to overflows for long-running UMA sessions even when per-UMA ping data is small enough.

Proposed solution here is to store the new UMA data in a separate HistogramSamples object  and flush it in the UMA ping.
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/498c838a685f07dda12f74620f9a13ae0cf62383

commit 498c838a685f07dda12f74620f9a13ae0cf62383
Author: altimin <altimin@chromium.org>
Date: Fri May 12 17:49:18 2017

[histogram] Make histograms more resistant to overflows.

Instead of calculating deltas from cumulative snapshots, store unlogged
histogram samples in a separate HistogramSample object.
This will reduce overflows from long-running sessions given that data
between UMA pings fits into 32-bit integer.

BUG=719446

Review-Url: https://codereview.chromium.org/2867303004
Cr-Commit-Position: refs/heads/master@{#471359}

[modify] https://crrev.com/498c838a685f07dda12f74620f9a13ae0cf62383/base/metrics/histogram.cc
[modify] https://crrev.com/498c838a685f07dda12f74620f9a13ae0cf62383/base/metrics/histogram.h
[modify] https://crrev.com/498c838a685f07dda12f74620f9a13ae0cf62383/base/metrics/histogram_base.h
[modify] https://crrev.com/498c838a685f07dda12f74620f9a13ae0cf62383/base/metrics/histogram_unittest.cc
[modify] https://crrev.com/498c838a685f07dda12f74620f9a13ae0cf62383/base/metrics/sparse_histogram.cc
[modify] https://crrev.com/498c838a685f07dda12f74620f9a13ae0cf62383/base/metrics/sparse_histogram.h
[modify] https://crrev.com/498c838a685f07dda12f74620f9a13ae0cf62383/base/metrics/sparse_histogram_unittest.cc
Project Member

Comment 2 by sheriffbot@chromium.org, May 14 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by dtapu...@chromium.org, Aug 31

Components: Internals>Metrics
►

Sign in to add a comment