Issue 719439 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	joelhockey@chromium.org
Closed:	May 2017
Cc:	joelhockey@chromium.org haraken@chromium.org dcheng@chromium.org
Components:	Blink>Internals>Frames
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Virtualize FrameView/RemoteFrameView methods where possible

Project Member Reported by kenrb@chromium.org, May 8 2017

Issue description

As noted by dcheng@ in https://codereview.chromium.org/2860903003/, some downcasts could be removed from Blink by moving LocalFrame::View() and RemoteFrame::View() into their common base class, and virtualizing more common methods between FrameView and RemoteFrameView.

Comment 1 by tkent@chromium.org, May 8 2017

Components: -Blink Blink>Internals

Comment 2 by dcheng@chromium.org, May 9 2017

Cc: haraken@chromium.org joelhockey@chromium.org
Components: -Blink>Internals Blink>Internals>Frames

For some more background, https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/FrameView.cpp?rcl=73b8f7ed8d1105af3d39563f30a2771aee24923f&l=4929 is one example where it would be nice to use virtual dispatch rather than manual downcasting: where possible, we've been trying to consolidate the codepaths for local and remote via virtual dispatch (since manual downcasting is often a sign of a bug where the remote frame case isn't correctly handled).

Comment 3 by joelhockey@chromium.org, May 18 2017

One question here is what the common base class could be named.  For consistency, it makes sense to rename current FrameView to LocalFrameView, and then have FrameView as common base class.  This change would be pretty big and a bit of a pain.  Does anyone else like this idea, or have suggestions?

Comment 4 by dcheng@chromium.org, May 18 2017

Renaming the current FrameView class to LocalFrameView makes sense to me.

Comment 5 by joelhockey@chromium.org, May 26 2017

Owner: joelhockey@chromium.org

Project Member

Comment 6 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5f851291ddd77204a5c18dd72d5fc7c1d30291

commit 6a5f851291ddd77204a5c18dd72d5fc7c1d30291
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri May 26 06:24:38 2017

Rename FrameView to LocalFrameView.  This matches naming for Frame / LocalFrame / RemoteFrame.

Bug:  719439 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I894af08090aace180312dfc11d2d773d35cd6d3f
Reviewed-on: https://chromium-review.googlesource.com/516862
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474939}
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/LayoutTests/inspector/tracing.html
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/animation/AnimationTimeline.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/animation/CompositorPendingAnimations.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/animation/DocumentAnimations.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/AffectedByPseudoTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/DragUpdateTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/MediaValuesInitialViewport.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/MediaValuesInitialViewportTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/StyleMedia.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/invalidation/StyleInvalidatorTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolverTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/AXObjectCache.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/CSSSelectorWatchTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/DocumentStatisticsCollectorTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/DocumentTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/ElementTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/ResizeObserver.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/Touch.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/ViewportDescription.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/EditingTestBase.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/FindInPageCoordinates.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/FrameCaretTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/commands/TypingCommandTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/iterators/SearchBufferTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/events/EventDispatcher.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/events/EventDispatcher.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/events/TouchEvent.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/events/WebInputEventConversion.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/events/WebInputEventConversion.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/FrameOrPlugin.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/LocalFrameTest.cpp
[rename] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[rename] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/ResizeViewportAnchor.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/RootFrameViewport.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/RotationViewportAnchor.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/RotationViewportAnchor.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/Screen.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/SmartClip.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/VisualViewport.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLEmbedElementTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLLinkElementTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/PluginDocument.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/TextControlElementTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/canvas/CanvasFontCacheTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/forms/PasswordInputTypeTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/input/EventHandlingUtil.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/ImageQualityController.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/IntersectionGeometry.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutFrame.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutPart.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutPart.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/api/LayoutItem.h
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/loader/DocumentWriter.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/6a5f851291ddd77204a5c18dd72d5fc7c1d30291/third_party/WebKit/Source/core/ori

Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3a1996f8a4dd79de7652a00e1797ce80e014a6

commit 8b3a1996f8a4dd79de7652a00e1797ce80e014a6
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri May 26 07:10:32 2017

FrameView as common base class for LocalFrameView and RemoteFrameView.

Bug:  719439 
Change-Id: I3e742aa5ffe59a9ad8be87af522cba22d2941c11
Reviewed-on: https://chromium-review.googlesource.com/516903
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474951}
[modify] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/frame/Frame.h
[add] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/frame/RemoteFrame.h
[modify] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/8b3a1996f8a4dd79de7652a00e1797ce80e014a6/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc164e82a40e8ac5bd0d80bf70ef38aa835ca438

commit fc164e82a40e8ac5bd0d80bf70ef38aa835ca438
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon May 29 03:40:10 2017

Make LocalFrameView::UpdateViewportIntersectionsForSubtree virtual on FrameView

Change RemoteFrameView::UpdateRemoteViewportIntersection to override
FrameView::UpdateViewportIntersectionsForSubtree, and now callers can
call a single method from Frame->View() rather than separate code for
local vs remote frames.

Bug:  719439 
Change-Id: I2c53891e5dbb8e9cba442ab6ffc8e346d18d125e
Reviewed-on: https://chromium-review.googlesource.com/517543
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475281}
[modify] https://crrev.com/fc164e82a40e8ac5bd0d80bf70ef38aa835ca438/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/fc164e82a40e8ac5bd0d80bf70ef38aa835ca438/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/fc164e82a40e8ac5bd0d80bf70ef38aa835ca438/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/fc164e82a40e8ac5bd0d80bf70ef38aa835ca438/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/fc164e82a40e8ac5bd0d80bf70ef38aa835ca438/third_party/WebKit/Source/core/frame/RemoteFrameView.h

Comment 9 by joelhockey@chromium.org, May 29 2017

Status: Fixed (was: Assigned)

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eebf634a7027c3aed5ee330fc461af750591e14

commit 0eebf634a7027c3aed5ee330fc461af750591e14
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Jun 08 00:13:19 2017

Rename FrameViewTest -> LocalFrameViewTest

to be consistent with the renamed LocalFrameView.

Bug:  719439 
Change-Id: Ia4b909871334730966f3a560a1457d1b55ef351c
Reviewed-on: https://chromium-review.googlesource.com/527874
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477818}
[modify] https://crrev.com/0eebf634a7027c3aed5ee330fc461af750591e14/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/0eebf634a7027c3aed5ee330fc461af750591e14/third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp

►

Issue 719439 link

Issue metadata

Virtualize FrameView/RemoteFrameView methods where possible

Issue description

Comment 1 by tkent@chromium.org, May 8 2017

Comment 1 Deleted

Comment 2 by dcheng@chromium.org, May 9 2017

Comment 2 Deleted

Comment 3 by joelhockey@chromium.org, May 18 2017

Comment 3 Deleted

Comment 4 by dcheng@chromium.org, May 18 2017

Comment 4 Deleted

Comment 5 by joelhockey@chromium.org, May 26 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, May 26 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, May 26 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, May 29 2017

Comment 8 Deleted

Comment 9 by joelhockey@chromium.org, May 29 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jun 8 2017

Comment 10 Deleted

Sign in to add a comment