Issue metadata
Sign in to add a comment
|
'Offer to translate pages in this language' checkbox is disabled for UI language.
Reported by
dchau...@etouch.net,
May 8 2017
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3093.0 (Official Build)b528d28ed46e08084f9b1a6a0e81fad09419176d-refs/heads/master@{#469894} 32/64-bit. OS: Windows (7,8,8.1,10). What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings/languages and add Hindi language from 'Add languages' overlay. 2. Select 'Display Google Chrome in this language' option from 'More actions' menu list for Hindi language. 3. Select 'Offer to translate pages in this language' option from 'More actions' menu list for Hindi language. 4. Again open the 'More actions' menu list and observe the 'Offer to translate pages in this language' checkbox. Unable to check the 'Offer to translate pages in this language' checkbox. Should be able to check the 'Offer to translate pages in this language' checkbox. This is a regression issue, broken in M-57 series, below is manual regression range. Good build: 57.0.2951.0 Bad build: 57.0.2952.0 Note: This issue is not reproducible on Mac and Linux OS. Kindly review the attached screen-cast for reference.
,
May 8 2017
Using the per-revision bisect providing the bisect results, Good build:57.0.2951.0-(Revision:438385). Bad build:57.0.2952.0-(Revision:438707). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/b6f207ca201f3eb08c2150f5c3610c68a30c8984..4cb2126002cd187035ba90ee13ebda77e16d81f6 Review-Url: https://codereview.chromium.org/2573643005 michaelpg@ Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thanks.
,
May 8 2017
Thanks for the bug report.
,
Aug 7 2017
Issue 748987 has been merged into this issue.
,
Sep 27 2017
Haven't looked at this in a while. Assigning to folks working on language settings.
,
Sep 27 2017
,
Oct 27 2017
This is related to crbug/167230.
,
Jan 29 2018
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95 commit e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95 Author: Claudio Magni <claudiomagni@chromium.org> Date: Wed Jan 31 02:52:58 2018 Allow Display UI for regional locales too. Currently some locales cannot be selected by the user as display UI, but this leads to a confusing experience because there are UI locales that are very similar (i.e. 'English' cannot be selected, but 'English (USA) can). This change fixes that. We increase the set of locales that can be selected and store the user selection in the Translate Prefs. Every time we read the Pref, we convert locales to their corresponding fallback if applicable. Bug: 719435 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1e41cb7d3a39160fbfb05571a573c1ebed2a7f91 Reviewed-on: https://chromium-review.googlesource.com/838726 Commit-Queue: Claudio M <claudiomagni@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@google.com> Cr-Commit-Position: refs/heads/master@{#533177} [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/about_flags.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/chromeos/hats/hats_dialog.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/chromeos/locale_change_guard.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/flag_descriptions.h [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/lifetime/application_lifetime.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/safe_browsing/BUILD.gn [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/common/pref_names.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/common/pref_names.h [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/service/DEPS [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/chrome/service/service_process.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/BUILD.gn [add] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/language/core/common/BUILD.gn [add] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/language/core/common/DEPS [add] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/language/core/common/locale_util.cc [add] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/language/core/common/locale_util.h [add] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/language/core/common/locale_util_unittest.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/translate/core/browser/BUILD.gn [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/translate/core/browser/translate_prefs.h [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/translate/core/common/BUILD.gn [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/translate/core/common/translate_util.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/translate/core/common/translate_util.h [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/components/translate/core/common/translate_util_unittest.cc [modify] https://crrev.com/e0a80bb7df2aafcf92f942bc2fe9dc3879fb7e95/tools/metrics/histograms/enums.xml
,
May 16 2018
,
May 20 2018
,
Jun 22 2018
,
Jun 22 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, May 8 2017Status: Untriaged (was: Unconfirmed)