ARC window always use MEDIUM elevation shadow |
||||||||||||
Issue descriptionARC window always use MEDIUM elevation shadow
,
May 9 2017
,
May 9 2017
,
May 9 2017
I think this worth merging and pretty safe.
,
May 9 2017
Merge approved for 58, assuming this is ARC++ specific. The description does not really say the problem this solves though, so I am not clear this should block a stable release.
,
May 10 2017
Yeah, it wasn't clear sorry. The shadow for active/inactive window should change, but ARC window was always using the same MEDIUM window.
,
May 10 2017
,
May 10 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5948bc0ef082e16b113f5158ef5d04f3b488ce4b commit 5948bc0ef082e16b113f5158ef5d04f3b488ce4b Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed May 10 05:17:35 2017 Use default shadow elevation. * Setting medium always use medium regardless of the active state. BUG= 719415 TEST=manual. Start ARC app and activate deactivate. Review-Url: https://codereview.chromium.org/2870613002 Cr-Commit-Position: refs/heads/master@{#470156} (cherry picked from commit 34e7e8f91cf42bbe67ff86b75e3aa616046ccccd) Review-Url: https://codereview.chromium.org/2872203002 . Cr-Commit-Position: refs/branch-heads/3029@{#837} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/5948bc0ef082e16b113f5158ef5d04f3b488ce4b/components/exo/shell_surface.cc [modify] https://crrev.com/5948bc0ef082e16b113f5158ef5d04f3b488ce4b/components/exo/shell_surface_unittest.cc
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2922d1fd61b584d688c6f99d6cf06e73606f36f4 commit 2922d1fd61b584d688c6f99d6cf06e73606f36f4 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed May 10 05:25:33 2017 Use default shadow elevation. * Setting medium always use medium regardless of the active state. BUG= 719415 TEST=manual. Start ARC app and activate deactivate. Review-Url: https://codereview.chromium.org/2870613002 Cr-Commit-Position: refs/heads/master@{#470156} (cherry picked from commit 34e7e8f91cf42bbe67ff86b75e3aa616046ccccd) Review-Url: https://codereview.chromium.org/2868253002 . Cr-Commit-Position: refs/branch-heads/3071@{#497} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/2922d1fd61b584d688c6f99d6cf06e73606f36f4/components/exo/shell_surface.cc [modify] https://crrev.com/2922d1fd61b584d688c6f99d6cf06e73606f36f4/components/exo/shell_surface_unittest.cc
,
May 10 2017
,
May 24 2017
,
Jan 22 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by bugdroid1@chromium.org
, May 9 2017