New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719414 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 716429



Sign in to add a comment

Notification Border is gone in message center

Project Member Reported by yoshiki@chromium.org, May 8 2017

Issue description

See the screenshot. A border should be visible around notifications in message center.

It looks https://crrev.com/2849523005/ is a direct cause. Reverting this solves the issue.
 
Screenshot 2017-05-08 at 20.07.36.png
40.3 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851fadadf0feb3dc4c4d12676a223db4b66a2010

commit 851fadadf0feb3dc4c4d12676a223db4b66a2010
Author: yoshiki <yoshiki@chromium.org>
Date: Mon May 08 17:04:59 2017

Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur

They look necessary because View::OnPaint draws the border, and View::OnFocus fires an accessibility event.

BUG= 719414 
TEST=manual (No issue happens)

Review-Url: https://codereview.chromium.org/2868833002
Cr-Commit-Position: refs/heads/master@{#470024}

[modify] https://crrev.com/851fadadf0feb3dc4c4d12676a223db4b66a2010/ui/message_center/views/message_view.cc

Labels: Merge-Request-59 M-59
 crbug.com/716429  has been merged so this also needs to be merged.
Project Member

Comment 3 by sheriffbot@chromium.org, May 10 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 716429
Let's merge this after  Issue 716429  is merged.
Project Member

Comment 6 by sheriffbot@chromium.org, May 15 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, May 19 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, May 19 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f9033dc07a052636a395a38859585aa623264df

commit 2f9033dc07a052636a395a38859585aa623264df
Author: Evan Stade <estade@chromium.org>
Date: Fri May 19 15:12:29 2017

Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur

They look necessary because View::OnPaint draws the border, and View::OnFocus fires an accessibility event.

BUG= 719414 
TEST=manual (No issue happens)

Review-Url: https://codereview.chromium.org/2868833002
Cr-Original-Commit-Position: refs/heads/master@{#470024}
Review-Url: https://codereview.chromium.org/2892943002 .
Cr-Commit-Position: refs/branch-heads/3071@{#631}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/2f9033dc07a052636a395a38859585aa623264df/ui/message_center/views/message_view.cc

Comment 9 by est...@chromium.org, May 19 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9460.48.0, 59.0.3071.67

Sign in to add a comment