New issue
Advanced search Search tips

Issue 71939 link

Starred by 21 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Pinned tab incorrectly reopens on start if last non-pinned tab was closed with tab close button

Reported by davey.mcglade@gmail.com, Feb 4 2011

Issue description

ChromeFrame version: 9.0.597.86 beta

Related URL(s):

Steps to reproduce the issue:
1. Pin an tab to the 
2. unpin tab
3. Pinned tab keeps reopening, even when homepage is set to www.google.com

What do you expect to happen?
Homepage loads

What do you see instead?
Pinned tab keeps reopening to last page opened.
 

Comment 1 by tommi@chromium.org, Feb 8 2011

Is this a problem with Chrome Frame or Chrome?

Comment 2 by tommi@chromium.org, Feb 9 2011

Labels: -Area-ChromeFrame Area-UI
assuming this is not cf related.
I have this problem too. Running Chromium 12.0.731.0

Somehow I have a pinned tab that always opens to http://google.com/contacts. I'm not sure how it got set to that URL, but it doesn't matter if I unpin it and close it, or if I go to that tab and go to a different URL -- when I close Chromium and open it back up the pinned tab is back and back to Google Contacts.
Labels: Mstone-13 Feature-TabStrip
Owner: a deleted user
Status: Assigned
Labels: -Mstone-13 Mstone-14 MovedFrom-13
Moving !type=meta|regression and !releaseblocker to next mstone
Moving !type=meta|regression and !releaseblocker to next mstone

Comment 7 by k...@google.com, Jul 28 2011

Labels: -Mstone-14 Mstone-15 MovedFrom-14
Punting out non-critical bugs.  Please move back to 14 if you believe this was done in error.

Comment 8 by keme...@gmail.com, Aug 8 2011

Oh so that's a bug. Have the same problem.

13.0.782.107
Windows 7 64-bit 

Comment 9 by kareng@google.com, Sep 8 2011

Labels: Mstone-16 MovedFrom16 bulkmove
moving all nonessential bugs from 15 to 16. please feel free to move back if this is an error and ur bug is a release blocker.

Comment 10 by laforge@google.com, Oct 24 2011

Labels: -Mstone-16 MovedFrom-16 Mstone-17

Comment 11 by k...@google.com, Dec 19 2011

Labels: -Mstone-17 Mstone-18 MovedFrom-17
Moving bugs marked as Assigned but not blockers from M17 to M18.  Please move back if you think this is a blocker, and add the ReleaseBlock-Stable label.  If you're able.

Comment 12 by kareng@google.com, Feb 7 2012

Labels: MovedFrom18 Mstone-19

Comment 13 by laforge@google.com, Mar 27 2012

Labels: -Mstone-19 Mstone-20 MovedFrom-19

Comment 14 by tv@duh.org, Apr 21 2012

This is very difficult to reproduce reliably, but it's still around in M19, probably in M20 (not yet reproduced there).

One thing that [almost] always seems to be the case is that it happens when I've opened a New Tab app, which has been set to "Open in a pinned tab", and Chrome/Chromium crashes while that tab is open.

After it gets into whatever state causes this issue, the pinned app tab will always pop up on a freshly started session. No amount of unpinning, or twiddling of the "On startup" settings, makes this auto-opened pinned tab go away. Eventually I have to blow away the profile directory and start over, re-syncing my prefs/bookmarks/etc. from the sync server.

Reproduced on Chrome 19.0.1084.30 beta, Linux, official build. "On startup" is set to "Open the New Tab page".

Comment 15 by k...@google.com, Apr 27 2012

Labels: -Mstone-20 MovedFrom-20
These bugs have hit their move limit.  Please re-target as appropriate.

Comment 16 by tv@duh.org, Aug 20 2012

I've stumbled upon a reliable test case in 21.0.1180.79. Finally!

First: Make sure "On startup" is set to "Open the New Tab page". Open a new session with only the New Tab page open.

Click on any app set to open as a pinned tab. (However, I've also successfully repro'd this by simply going to any website and manually pinning a tab.)

Close Chrome entirely with *SHIFT-CTRL-W*, not the close button or ^W'ing all tabs.

Wait a moment for all subprocesses to close, then reopen Chrome.

Pinned tab reappears to the left of a blank (New Tab page) tab.

Comment 17 by tv@duh.org, Aug 20 2012

Note: previous repro was done on Linux, not Windows. I suspect this is an OS-independent issue. (Though of course the keyboard shortcut to repro will be different on Mac.)

Comment 18 by tv@duh.org, Aug 20 2012

One more comment for today; sorry for the spam.

I now realize that all the past times where this has happened, I've either done a full quit with Shift-Ctrl-W or Chrome has itself completely crashed while a pinned tab was opened. For some reason this doesn't affect the code path from using the window-close button.

A temporary fix for those afflicted is to open Chrome, close the auto-reopened tab, then Shift-Ctrl-W to quit Chrome (probably Shift-Cmd-W on Mac, untested by me). On next launch, the pinned tab should be gone.

Comment 19 by tv@duh.org, Aug 21 2012

...and a careless click on the window-close button tonight shows me that in fact the problem does exist there too, contrary to what I said above. (This will only affect Windows and Linux, as closing the window does not completely exit the application on Mac.)

Comment 20 by styu...@gmail.com, Oct 26 2012

Still exists on Windows.

Chrome opens with the pinned tab (previously unpinned and closed), even if the startup setting is "Open the New Tab page" or "Open a specific page or set of pages.". When the "Continue where I left off" setting is active, the pinned tab DOESN'T shows up, but the pinned tab reappears after changing the setting back to one of the others.

This bug is very annoying, please fix it ASAP.
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-TabStrip Cr-UI-Browser-TabStrip Cr-UI

Comment 22 by tv@duh.org, Jun 27 2013

Still exists on Linux Chrome 28. This looks cross-platform; OS-Windows label should be removed.

Comment 23 by tv@duh.org, Jun 27 2013

BTW, this bug is making users of some apps blame the apps for their pinned tabs reopening every startup:

https://feedly.uservoice.com/forums/192636-suggestions/suggestions/4111243-do-not-auto-pin-tabs-in-chrome-or-any-other-browse

There's a very reliable test case here; simply pin a tab, then use the full Exit action (menu -> Exit, close button on the whole window, Shift-Ctrl-W/Shift-Ctrl-Q/Shift-Cmnd-W/Shift-Cmnd-Q.

After doing so, the pinned tab reappears on next session start.

Comment 24 by tv@duh.org, Sep 26 2013

Still affects 30.0.1599.59 as of this writing.

This reproduces more simply when background running is off. However, it can also be reproduced by closing the only open window (while a pinned tab is open within that window) via the window close button, then choosing Exit from the tray icon context menu. Likewise, the way to clear this state is to close the only open window (with *no* pinned tab in it) via the window close button, then choosing Exit from the tray icon.

Note that this should be OS-All. It is reproduceable in 30.0 on at least Windows 7 and Linux Ubuntu 12.04.

Comment 25 by Deleted ...@, Apr 30 2014

This problem still affects me using 
"Chromium 34.0.1847.116 Ubuntu 14.04 aura (260972)"

Pretty annoying :S

Comment 26 by tv@duh.org, Apr 30 2014

Confirmed; it's still there for up-to-date 34 and 35 as of this writing, Windows and Linux at least.
Confirmed still an issue as of Version 35.0.1916.153 m

Comment 28 by sach...@gmail.com, Aug 1 2014

Issue confirmed in Chromium version 36.0.1985.125 (283153) running on Linux
Still not working in newest version of Chrome.

I managed to reproduce it that way:
-Open a webpage ie (www.test.com)
-Pin the tab
-Browse to a *different domain* with this tab
-Re-open the browser and you will never get rid of that tab again, you can try and try

Only solution is:
-Activate the tab and browse back to the *original domain*
-Restart the browser and its gone




Occurring here, again.

Windows 8, 64-bit
Chrome Version 40.0.2214.115 m
Occurred here right now, testing messenger.com. 

Windows 7 SP1, 64-bit
Chrome Version 42.0.2311.82 beta-m (64-bit)

Solution I've found working is make sure you have a New Tab page opened. Close the pinned tab. Then close the browser ONLY via the drop-down menu to the far right of the navbar, choosing "Exit" at the bottom. Note you MUST use the "Exit" menu item in order for this to work.

Can't believe this is still around since February 2011.

Comment 32 by Deleted ...@, Oct 10 2015

This bug still exists under Ubuntu 15.04 and is very annoying. At least the workaround in #31 works for now.

Comment 33 by Deleted ...@, Nov 13 2015

had this problem in windows 8.1 with Chrome ver 46... only way i found that works is to either close from menu > exit OR Ctrl + Shift + Q . not sure if this helps anyone or not but i was getting very annoyed by it.

Comment 34 by Deleted ...@, Dec 23 2015

Are you kidding me? It will be 2016 in next 8 days and this bug still alive since 2011. On February, 4th we can celebrate its 5th anniversary. What are you doing there, drinking vodka?

Ubuntu 14.04 Chrome Version 47.0.2526.106 (64-bit)
This is such a simple code fix to make and removes a really irritating bug... PLEASE sort it out! Users should not have to come up with workarounds!

Comment 36 by tv@duh.org, Jan 10 2017

Ping. Ping. Ping. Ping. Ping. Ping. Ping. Ping.

Just under six years and nobody has even analyzed this. Hello? What can we do to help debug this?
Cc: pkasting@chromium.org
Labels: -MovedFrom-17 -MovedFrom-13 -MovedFrom-14 -MovedFrom-19 -MovedFrom18 -MovedFrom-20 -MovedFrom-16 -bulkmove -MovedFrom16 Needs-Feedback
Status: Unconfirmed (was: Assigned)
I'm not able to reproduce problems here.

* If Chrome is closed with a pinned tab open, the pinned tab will reappear on next startup regardless of startup setting.  This is intentional; it's part of what pinning a tab means.
* If I close the pinned tab before closing Chrome, the pinned tab does not reappear on restarting Chrome.  I tried different methods of closing Chrome (e.g. ctrl-shift-w, closing the window with the X button, etc.); I tried navigating the pinned tab to a different domain than it had launched with before shutting down; etc.

It seems like there's a combination of things going on here:
* I don't understand what's being reported
* Some intentional behaviors (e.g. pinned tabs auto-reopening on next launch if they were open at shutdown) are being seen as bugs

I would appreciate it if someone could take the time to give really precise steps to reproduce what they think is wrong, and point out exactly where the perceived bug is.

Comment 38 by tv@duh.org, Jan 10 2017

"If Chrome is closed with a pinned tab open, the pinned tab will reappear on next startup regardless of startup setting.  This is intentional; it's part of what pinning a tab means."

Well, that has not been clear. If this is intentional, fine, I can live with that.

However the following testcase is the specific one which does *not* properly remove the pinned tab from the list of tabs to open on startup; this is the inconsistency seen in this bug:

1. Start clean session.
2. Open a new tab, navigate it somewhere, pin it.
3. Close with Ctrl-Shift-W or the window close button; ensure that everything exits (no background processes except optionally --service).

4. Open new session. Pinned tab returns, as expected per above clarification.
5. Close pinned tab.
6. Close last tab in the window by the *TAB's* close button. (DO NOT click window close button or Ctrl-Shift-W.) This closes Chrome; ensure that everything exits again.

7. Open new session. *Pinned tab, which was previously closed in step 5, is back!* (Oops.)

Comment 39 by tv@duh.org, Jan 10 2017

BTW, whether the pinned tab in step 5 is unpinned before closing it doesn't matter. It's the act of closing Chrome via a *tab* close button (or plain Ctrl-W) which does not save this change.
Components: -UI UI>Browser>Sessions
Labels: -Pri-2 -Needs-Feedback Pri-3
Status: Assigned (was: Unconfirmed)
Summary: Pinned tab incorrectly reopens on start if last non-pinned tab was closed with tab close button (was: Pinned tabkeeps reopening even when unpinned)
Yup, comment 38 is definitely a bug.  Thanks for a clear set of steps!

Scott, is having this assigned to you appropriate?

Comment 41 by tv@duh.org, Jan 10 2017

Nitpick on new subject line: It also happens if the last tab closed was still pinned, but closed with Ctrl-W (or right-click-tabstrip-Close, which is equivalent). What it should do in this case is ambiguous.

To me, the fact that it's a close action on the _tab_ feels like it should remove the pinned tab from session restart, rather than keeping it. (Plus, same issue if you have two pinned tabs open and ^W all the way until Chrome closes -- _all_ pinned tabs return.)

BTW, one possible major behavior change, which would also eliminate this ambiguity, would be to disallow directly closing a pinned tab (forcing it to be unpinned before closing). This way, all windows with pinned tabs slated for reopening would be required to close via whole session close (Ctrl-Shift-W or window close). This has the added benefit that it jives with the tabstrip UI, which offers no close button for a pinned tab.

Comment 42 by sky@chromium.org, Jan 10 2017

I'm not going to have time for this anytime soon, if you have the cycles please take it.
Owner: ----
Status: Available (was: Assigned)
@41: I agree with you that explicitly closing the last tab, directly, means it shouldn't be restored.  That's bug 431822.

I don't have time to tackle this bug, but I've sent an email to a relevant PM asking whether another team can take over sessions bugs in general.
Hi, everyone. I'd like to give it a try. May I take this issue?
Project Member

Comment 45 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc4f172dfe2167666aff966b119181c57639e46d

commit dc4f172dfe2167666aff966b119181c57639e46d
Author: sangwoo.ko <sangwoo108@gmail.com>
Date: Fri Feb 16 22:49:46 2018

Try saving pinned tabs on OnBrowserRemoved

Bug:71939

PinnedTabService is observing two events:
NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST and BrowserList::OnBrowserClosing.

The first is when users want to shut down entire app and
the latter is when users close a browser at once even if it has multiple tabs.

But the bug is edge case which doesn't belong to any case above for now.
When tab strip is empty, BrowserListObserver::OnBrowserClosing is not called even
this will end up with closing the browser.

So try saving pinned tabs again on BrowserListObserver::OnBrowserRemoved.

Change-Id: Id73891b9509918bca3b1dcaf0b34cc32a7a687a7
Test: PinnedTabServiceBrowserTest.*
Reviewed-on: https://chromium-review.googlesource.com/892539
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537442}
[modify] https://crrev.com/dc4f172dfe2167666aff966b119181c57639e46d/chrome/browser/ui/tabs/pinned_tab_service.cc
[modify] https://crrev.com/dc4f172dfe2167666aff966b119181c57639e46d/chrome/browser/ui/tabs/pinned_tab_service.h
[add] https://crrev.com/dc4f172dfe2167666aff966b119181c57639e46d/chrome/browser/ui/tabs/pinned_tab_service_browsertest.cc
[modify] https://crrev.com/dc4f172dfe2167666aff966b119181c57639e46d/chrome/test/BUILD.gn

Status: Fixed (was: Available)
I believe this is fixed. If this still happens, please re-triage this :)
June 11, 2018 - this problem persists.  I have attempted to search for solutions and tried numerous ways to unpin tabs and close the browser. The pinned tabs return. I do not wish to uninstall and reinstall Chrome. Thank you.
@47: Can you say what version of Chrome you're using and what steps you used to reproduce the problem?  The steps in comment 38 no longer show a problem for me on Chrome Dev.

Sign in to add a comment