Regression: Data is getting saved when the window is closed using enter button in Auto-fill settings |
|||||||||||
Issue descriptionChrome Version: 60.0.3093.0 OS: Ubuntu 14.04, Windows Steps to reproduce the problem: 1. Launch Chrome, go to chrome://settings>> Auto-fill settings 2. Enter data in addresses fields/credit card fields and keep tabbing until the focus reaches the close button 3. Hit enter button and observe What is the expected behavior? Data should not be saved when we close the window What went wrong? Data is getting saved when we close the window This is regression issue broken in 'M 59' Manual Bisect Info: Good Build: 59.0.3061.0 Bad Build: 59.0.3062.0
,
May 8 2017
,
May 8 2017
,
May 8 2017
Able to reproduce the issue on Windows 7,Ubuntu 14.04 & Mac 10.12.4 using latest Canary #60.0.3091.0 Manual Bisect: ------------- Good Build: 59.0.3061.0 -Revision-461353 Bad Build: 59.0.3062.0-Revision-461587 Using per-revision bisect providing the bisect results: You are probably looking for a change made after 461584 (known good), but no later than 461585 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/20e2934528d1d7332529212f6d7295ac87198107..0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b Possible suspect: ---------------- https://chromium.googlesource.com/chromium/src/+/0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b Review-Url: https://codereview.chromium.org/2788673003 tommycli@,Could you please taka a look into this & reassign if this issue is not related to your change. Thanks..!!
,
May 8 2017
I am wondering if this happens to other dialogs too, for example the reset profile dialog.
,
May 15 2017
Same issue is reproduced in Import bookmarks and settings 1. Launch Chrome, go to chrome://md-settings/importData 2. keep tabbing until the focus reaches the close button, Hit enter button and observe Actual: Window is not closed Expected: Window should be closed
,
May 16 2017
,
May 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d760627f0528f7ac3969c4109ba33abb2265b5c3 commit d760627f0528f7ac3969c4109ba33abb2265b5c3 Author: tommycli <tommycli@chromium.org> Date: Tue May 16 18:07:04 2017 WebUI: Stop keypresses on the close icon from firing the Enter handler. Previously, Enter keypresses on the close icon could trigger the whole dialog's default Enter handler. This CL prevents that. BUG= 719387 TEST=MANUAL R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2884113002 Cr-Commit-Position: refs/heads/master@{#472159} [modify] https://crrev.com/d760627f0528f7ac3969c4109ba33abb2265b5c3/chrome/test/data/webui/cr_elements/cr_dialog_test.js [modify] https://crrev.com/d760627f0528f7ac3969c4109ba33abb2265b5c3/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/d760627f0528f7ac3969c4109ba33abb2265b5c3/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
May 16 2017
Requesting merge. Haven't verified on Canary yet, but will verify tomorrow once it lands in Canary.
,
May 17 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 18 2017
Verified on Canary. I'm executing the merge now.
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acd447c3e9f8477a25a76054f7b940728da30107 commit acd447c3e9f8477a25a76054f7b940728da30107 Author: Tommy C. Li <tommycli@chromium.org> Date: Thu May 18 17:40:14 2017 WebUI: Stop keypresses on the close icon from firing the Enter handler. Previously, Enter keypresses on the close icon could trigger the whole dialog's default Enter handler. This CL prevents that. BUG= 719387 TEST=MANUAL R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2884113002 Cr-Original-Commit-Position: refs/heads/master@{#472159} Review-Url: https://codereview.chromium.org/2891993002 . Cr-Commit-Position: refs/branch-heads/3071@{#617} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/acd447c3e9f8477a25a76054f7b940728da30107/chrome/test/data/webui/cr_elements/cr_dialog_test.js [modify] https://crrev.com/acd447c3e9f8477a25a76054f7b940728da30107/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/acd447c3e9f8477a25a76054f7b940728da30107/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
May 18 2017
,
May 24 2017
Verified this issue on Win 10, Mac 10.12.4, Ubuntu 14.04 using chrome latest Beta M59 #59.0.3071.71 by following steps mentioned in the original comment. Observed the data is not saving now on clicking close button. Hence adding the TE- Verified label Please refer the screen cast Thanks, |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by sc00335...@techmahindra.com
, May 8 2017Components: -UI UI>Settings
Labels: -Type-Bug -Pri-2 -Via-Wizard-UI Needs-Bisect M-60 OS-Windows Pri-1 Type-Bug-Regression