New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 719336 link

Starred by 2 users
Status: Verified
Owner:
yhanada@chromium.org
Closed: May 2017
Cc:
█ yoshiki@chromium.org
edcourtney@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Delete MessageViews after "Clear All" operation.

Project Member Reported by yhanada@chromium.org, May 8 2017 
Now MessageViews that are cleared by "Clear All" operation are not deleted.
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/051bc03146abba0fa2f15331e8ea04e0d3d98d92

commit 051bc03146abba0fa2f15331e8ea04e0d3d98d92
Author: yhanada <yhanada@chromium.org>
Date: Mon May 08 10:47:51 2017

Delete MessageViews cleared by "Clear All" after animation.

BUG= 719336 
TEST=Added unittests in message_center_unittests.

Review-Url: https://codereview.chromium.org/2868793002
Cr-Commit-Position: refs/heads/master@{#469955}

[modify] https://crrev.com/051bc03146abba0fa2f15331e8ea04e0d3d98d92/ui/message_center/views/message_list_view.cc
[modify] https://crrev.com/051bc03146abba0fa2f15331e8ea04e0d3d98d92/ui/message_center/views/message_list_view_unittest.cc

Comment 2 by yhanada@chromium.org, May 8 2017

Status: Fixed (was: Assigned)

Comment 3 by sdantul...@chromium.org, May 18 2017 

yhanada@ Trying to verify this bug. Does this require any verification from UI side?

Comment 4 by yhanada@chromium.org, May 18 2017 

This is a pure memory management issue, so it doesn't require any verification from UI side. Thanks!

Comment 5 by sdantul...@chromium.org, May 18 2017

Status: Verified (was: Fixed)
Thanks yhanada@ !!
►

Sign in to add a comment