New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 719325 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: May 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Spacing Issue is observed on chrome://settings/searchEngines.

Reported by aiman.an...@etouch.net, May 8 2017 
Chrome Version: 60.0.3093.0 (Official Build) (cohort: win_58_96) b528d28ed46e08084f9b1a6a0e81fad09419176d-refs/heads/master@{#469894}(32/64-bit)

OS: Windows(7,8,8.1,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.1, 10.12).

Steps to reproduce:
1. Launch chrome, go to chrome://settings/searchEngines, Click on ADD Button for Other Search Engines.
2. On Add Search Engine Overlay, add data, enter long text input for Keyword field (e.g. 'gdhgdfhdfhdfhjfdjgvnvcncvnmcvbcxbdf').
3. Observe.

Actual Result: Spacing Issue is observed between Keyword and Query URL.
Expected Result: Spacing issue should not be seen.

This is Regression issue broken in M-58,  will soon update other info

Manual Bisect:
Good Build: 58.0.3013.0 
Bad Build: 58.0.3014.0
Actual Result.mp4
819 KB View Download
Expected Result.mp4
777 KB View Download
Result.png
36.9 KB View Download

Comment 1 by rbasuvula@chromium.org, May 8 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:58.0.3013.0 (Revision:450530).
Bad build:58.0.3014.0 (Revision:450840).

You are probably looking for a change made after 450799 (known good), but no later than 450800 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/c30cc0c6a478e9471680ab1218c2d2a649d6cb25..13ff49ec46586eb4aa206226dcf3bef5cf02d5b4

From the CL above, assigning the issue to the concern owner

@dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2693253002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #60.0.3093.0

Comment 2 by dpa...@chromium.org, May 8 2017

Labels: Proj-MaterialDesign-WebUI

Comment 3 by dpa...@chromium.org, May 8 2017

Labels: Hotlist-MD-Settings-SearchEngines

Comment 4 by dpa...@chromium.org, May 16 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e66cc545cc1e3f6fdd36a79b9871d746369fa38e

commit e66cc545cc1e3f6fdd36a79b9871d746369fa38e
Author: dpapad <dpapad@chromium.org>
Date: Wed May 17 19:15:17 2017

MD Settings: Search engines, improve spacing for long keywords.

BUG= 719325 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885673002
Cr-Commit-Position: refs/heads/master@{#472524}

[modify] https://crrev.com/e66cc545cc1e3f6fdd36a79b9871d746369fa38e/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Comment 6 by dpa...@chromium.org, May 17 2017

Status: Fixed (was: Started)

Comment 7 by jmukthavaram@chromium.org, May 23 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3107.4
Tested the issue on windows 7, Mac 10.12.4, Linux Ubuntu 14.04 using chrome version#60.0.3107.4 with the steps mentioned in comment #0.Spacing issue  is not observed on chrome://settings/searchEngines. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.
Thanks!!
719325.mp4
748 KB View Download
►

Sign in to add a comment