Issue metadata
Sign in to add a comment
|
Regression: Unnecessary blink of separator is observed on hovering security indicators.
Reported by
abom...@etouch.net,
May 8 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:60.0.3093.0 (Official Build) b528d28ed46e08084f9b1a6a0e81fad09419176d-refs/heads/master@{#469894} OS: Mac (10.12.3, 10.11.6) What steps will reproduce the problem? 1. Launch chrome (NTP or Incognito window) and navigate to any webpage (https://permission.site/) 2. Hover on security indicators and observe separator. Actual: Unnecessary blink of separator is observed on hovering security indicators. Expected: Blink of separator should not be seen. (i.e Grey highlight of hovering effect should not overlap on separator) This is regression issue, broken in ‘ M 60’ and below is manual bisect info: Good build:60.0.3090.0 Bad build:60.0.3091.0 Note: Issue is not seen on Windows and Linux OS.
,
May 8 2017
I think, this is because the divider has no longer the same color like the hover button and the divider is no longer aligned with the right border of the hover button (it is 1pt more to the left now).
,
May 8 2017
(It is not really 1pt more to the left: before it was 2pt and now it is reduced 1pt on the right side)
,
May 8 2017
If I understand this bug correctly, the issue is now that the separator is no longer being dithered between two columns of pixels it's darker (?) and it's glaring to see the separator swap out and the lighter gray hover background take its place? I think the separator probably needs to move to px to the right from where it is currently, but I don't think that will make the transition less jarring (the separator will still overlap the hover background highlight).
,
May 9 2017
Hi, the separator is now nicely centered between Chip and Omnibox text. Moving it 1px to the right, it would probably make it also necessary to move the Omnibox text 1px to the right to not lose the nice centering.
,
May 9 2017
+ screenshots
,
May 9 2017
I also realized that I also tweaked the color of the separator to match spec, which is a darker color than was being used. So that is probably the reason for the difference between the divider and hover color. I'm thinking this is working as intended.
,
May 29 2017
I think the divider appears to be jumping a tiny bit during the transition because the right edge of the hover-background doesn't line up precisely with the divider. Would it be possible to slightly reduce the width of the hover-background to fix this?
,
May 30 2017
,
Jun 28 2017
We're almost out of time for merges into M-60. Is this Pri-1 bug targeting M-60 intended to make it into the release?
,
Jun 28 2017
,
Sep 8 2017
I think we can close this - this seems to be fixed in latest Canary Version 63.0.3210.0 on macOS 10.12.6. The the right edge of the hover button is now lined up perfectly with the divider as requested in the specs in comment#8. spqchan@: Could this been fixed with your latest refactor from Issue 760729 ? Screencast is attached.
,
Sep 8 2017
(An additional note to my latest comment: I only checked it on a Non-Retina display)
,
Sep 12 2017
Thanks for pointing this out, mehmet@! Yes, it looks like my refactor might have fixed it, since it fixed some issues with the drawings. I'll go ahead and close this bug |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abom...@etouch.net
, May 8 2017Labels: hasbisect
Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)